Re: [dpdk-dev] [PATCH] net/bonding: set started flag at the end of dev start

2018-07-25 Thread Radu Nicolau
On 7/24/2018 3:34 PM, Chas Williams wrote: I think this adds another race.  In bond_ethdev_slave_link_status_change_monitor(), it checks to see if bonding is started, if not it exits.  So you need to have dev_started = 1 set before you enable this callback. Indeed, I will have another loo

Re: [dpdk-dev] [PATCH] net/bonding: set started flag at the end of dev start

2018-07-24 Thread Chas Williams
I think this adds another race. In bond_ethdev_slave_link_status_change_monitor(), it checks to see if bonding is started, if not it exits. So you need to have dev_started = 1 set before you enable this callback. On Fri, Jul 20, 2018 at 6:09 AM Radu Nicolau wrote: > Race condition can appear i

[dpdk-dev] [PATCH] net/bonding: set started flag at the end of dev start

2018-07-20 Thread Radu Nicolau
Race condition can appear in the bond_mode_8023ad_periodic_cb() callback when bonding port is stopped, reconfigured and restarted. Fixes: 2efb58cbab6e ("bond: new link bonding library") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_pmd.c | 3 +-- 1 file ch