Re: [dpdk-dev] [PATCH] net/bonding: fix segfault using invalid port

2019-10-29 Thread Yang, Qiming
Thanks for the information, got it. Qiming > -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, October 29, 2019 2:26 PM > To: Yang, Qiming > Cc: Jiang, JunyuX ; dev@dpdk.org; Chas Williams > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/bondin

Re: [dpdk-dev] [PATCH] net/bonding: fix segfault using invalid port

2019-10-28 Thread Ye Xiaolong
On 10/29, Yang, Qiming wrote: >> -Original Message- >> From: Ye, Xiaolong >> Sent: Tuesday, October 29, 2019 11:04 AM >> To: Yang, Qiming >> Cc: Jiang, JunyuX ; dev@dpdk.org; Chas Williams >> ; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] ne

Re: [dpdk-dev] [PATCH] net/bonding: fix segfault using invalid port

2019-10-28 Thread Yang, Qiming
> -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, October 29, 2019 11:04 AM > To: Yang, Qiming > Cc: Jiang, JunyuX ; dev@dpdk.org; Chas Williams > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix segfault using invalid port > > O

Re: [dpdk-dev] [PATCH] net/bonding: fix segfault using invalid port

2019-10-28 Thread Ye Xiaolong
On 10/28, Yang, Qiming wrote: >Hi, Junyu > >> +dev = &rte_eth_devices[port]; >> +internals = dev->data->dev_private; >Have you build success? I think we need to add (struct bond_dev_private *) for >force transfer dev_private is a void *, an explicit type conversion is not needed here. Th

Re: [dpdk-dev] [PATCH] net/bonding: fix segfault using invalid port

2019-10-27 Thread Yang, Qiming
Hi, Junyu > -Original Message- > From: Jiang, JunyuX > Sent: Friday, October 25, 2019 4:56 AM > To: dev@dpdk.org > Cc: Chas Williams ; Yang, Qiming ; > Jiang, JunyuX ; sta...@dpdk.org > Subject: [PATCH] net/bonding: fix segfault using invalid port > > Port validation should be prior to ge

[dpdk-dev] [PATCH] net/bonding: fix segfault using invalid port

2019-10-24 Thread Jiang JunyuX
Port validation should be prior to getting dev data to avoid segmentation fault. This patch fixed the issue. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Cc: sta...@dpdk.org Signed-off-by: Jiang Junyu