Re: [dpdk-dev] [PATCH] mk: fix build of assembly files for ARM64

2017-01-27 Thread Thomas Monjalon
2017-01-18 12:31, Zbigniew Bodek: > > On 17.01.2017 23:45, Thomas Monjalon wrote: > > 2017-01-17 15:35, zbigniew.bo...@caviumnetworks.com: > >> -# for now, we don't use as but nasm. > >> -# AS = $(CROSS)as > > > > It looks to be a very very old comment. > > > >> +ifeq ($(CONFIG_RTE_ARCH_X86),

Re: [dpdk-dev] [PATCH] mk: fix build of assembly files for ARM64

2017-01-18 Thread Zbigniew Bodek
On 17.01.2017 23:45, Thomas Monjalon wrote: 2017-01-17 15:35, zbigniew.bo...@caviumnetworks.com: -# for now, we don't use as but nasm. -# AS = $(CROSS)as It looks to be a very very old comment. +ifeq ($(CONFIG_RTE_ARCH_X86),y) AS= nasm There is no asm file in DPDK as far as

Re: [dpdk-dev] [PATCH] mk: fix build of assembly files for ARM64

2017-01-17 Thread Thomas Monjalon
2017-01-17 15:35, zbigniew.bo...@caviumnetworks.com: > -# for now, we don't use as but nasm. > -# AS = $(CROSS)as It looks to be a very very old comment. > +ifeq ($(CONFIG_RTE_ARCH_X86),y) > AS= nasm There is no asm file in DPDK as far as I know. So why would we have a dependency o

[dpdk-dev] [PATCH] mk: fix build of assembly files for ARM64

2017-01-17 Thread zbigniew.bodek
From: Zbigniew Bodek Avoid using incorrect assembler (nasm) and unsupported flags when building for ARM64. Fixes: af75078fece3 ("first public release") Fixes: b3ce00e5fe36 ("mk: introduce ARMv8 architecture") Signed-off-by: Zbigniew Bodek Reviewed-by: Jerin Jacob Acked-by: Hemant Agrawal ---