[dpdk-dev] [PATCH] mk: Fix examples install

2016-01-19 Thread Thomas Monjalon
2016-01-08 12:03, Christian Ehrhardt: > Depending on non-doc targets being built before and the setting of DESTDIR > the copy of the examples dir being part of install-doc could in some cases > fail > with a non existant "$(DESTDIR)$(datadir)" target directory. > Add the conditional rte_mkdir for

[dpdk-dev] [PATCH] mk: Fix examples install

2016-01-18 Thread Christian Ehrhardt
Hi, Since there was neither positive nor negative feedback so far I wanted to ask if this patch is ok? Especially since we had a discussion on the approach I chose in the first approach to this issue I'd be happy about a ack/nak. Kind Regards, Christian Christian Ehrhardt Software Engineer, Ubu

[dpdk-dev] [PATCH] mk: Fix examples install

2016-01-08 Thread Christian Ehrhardt
Forgot to mention, an easy way to test-trigger this e.g. on the dpdk 2.2 tarball. make clean; make config T=x86_64-native-linuxapp-gcc && && make -j && make V=1 DESTDIR=Test install-doc In this example the install-doc fails with this: [...] Build complete [x86_64-native-linuxapp-gcc] make -f /hom

[dpdk-dev] [PATCH] mk: Fix examples install

2016-01-08 Thread Christian Ehrhardt
Depending on non-doc targets being built before and the setting of DESTDIR the copy of the examples dir being part of install-doc could in some cases fail with a non existant "$(DESTDIR)$(datadir)" target directory. Add the conditional rte_mkdir for that to avoid the issue. Signed-off-by: Christia

[dpdk-dev] [PATCH] mk: Fix examples install path

2016-01-08 Thread Christian Ehrhardt
Hi Thomas, sorry being away so long due to the Christmas break. May bad assumption of being a typo was based on a coincidence combining a) former packaging in ubuntu had it in fact under /usr/share/doc/dpdk (I agree that just /usr/share/dpdk would be better) b) if you just and only ran a build an

[dpdk-dev] [PATCH] mk: Fix examples install path

2015-12-23 Thread Thomas Monjalon
Hi, 2015-12-22 14:13, Christian Ehrhardt: > Depending on non-doc targets being built before and the setting of DESTDIR > the examples dir could in some cases not end up in the right target. > Reason is just a typo variable reference in the copy target. [...] > - $(Q)cp -a $(RTE_SDK)/examples $

[dpdk-dev] [PATCH] mk: Fix examples install path

2015-12-22 Thread Christian Ehrhardt
Depending on non-doc targets being built before and the setting of DESTDIR the examples dir could in some cases not end up in the right target. Reason is just a typo variable reference in the copy target. Signed-off-by: Christian Ehrhardt --- [diffstat] rte.sdkinstall.mk |2 +- 1 file chan