Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), remove useless variable

2017-12-01 Thread Olivier MATZ
Hi Ilya, On Tue, Nov 14, 2017 at 05:44:49PM +0400, Ilya Matveychikov wrote: > Fixes: af75078fece3 ("first public release") > Cc: intel.com The Cc tag seems wrong, should be removed. > Signed-off-by: Ilya V. Matveychikov > --- > > There is no reason to have local variable m2 or am I wrong? Yes

Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), remove useless variable

2017-11-14 Thread Ilya Matveychikov
> On Nov 15, 2017, at 12:32 AM, Hanoch Haim (hhaim) wrote: > > I would add this too > > - } else if (rte_atomic16_add_return(&m->refcnt_atomic, -1) == 0) > > Should be : > > + } else if (likely(rte_mbuf_refcnt_update(m, -1) == 0)) { > > > Hanoh > Why not to send the separate patch for t

Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), remove useless variable

2017-11-14 Thread Hanoch Haim (hhaim)
mber 14, 2017 3:45 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), remove useless variable Fixes: af75078fece3 ("first public release") Cc: intel.com Signed-off-by: Ilya V. Matveychikov --- There is no reason to have local variable m2 or

[dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), remove useless variable

2017-11-14 Thread Ilya Matveychikov
Fixes: af75078fece3 ("first public release") Cc: intel.com Signed-off-by: Ilya V. Matveychikov --- There is no reason to have local variable m2 or am I wrong? lib/librte_mbuf/rte_mbuf.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib