Re: [dpdk-dev] [PATCH] lpm: skip table entries update if rules found

2020-04-17 Thread Yangchao Zhou
++ dev@dpdk.org On Fri, Apr 17, 2020 at 10:38 PM Yangchao Zhou wrote: > Hi Vladimir, > > Thanks, you are right. I saw that the next hop is also in lpm table > entries. > On the basis of the same route, skiping the table entries update only if > the next hop is also the same. > > On Fri, Apr 17,

Re: [dpdk-dev] [PATCH] lpm: skip table entries update if rules found

2020-04-17 Thread Medvedkin, Vladimir
Hi Zhou, NACK. This patch makes lpm inconsistent. >From the programmers guide "If a rule with the same prefix is already present in the table, the next hop of the rule is updated." So, here in case of presence of a route, next hop will be updated only in rules_table which is helper data struct,

[dpdk-dev] [PATCH] lpm: skip table entries update if rules found

2020-04-17 Thread Yangchao Zhou
Table entries do not need to be updated if the same rules can be found. Signed-off-by: Yangchao Zhou --- lib/librte_lpm/rte_lpm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index 268756419..ee44fc4e5 100644 --- a/l