[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-24 Thread Xuelin Shi
Hi Thomas, Done. http://patchwork.dpdk.org/dev/patchwork/patch/4122/ Thanks, Xuelin Shi > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, March 23, 2015 22:04 > To: Shi Xuelin-B29237 > Cc: Bruce Richardson; dev at dpdk.org > Subject: Re:

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-23 Thread Thomas Monjalon
2015-03-09 14:02, Bruce Richardson: > On Wed, Mar 04, 2015 at 02:34:12PM +0800, xuelin.shi at freescale.com wrote: > > From: Xuelin Shi > > > > This module uses type conversion between struct and int. > > Also truncation and comparison is used with this int. > > It is not safe for different endia

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-09 Thread Thomas Monjalon
2015-03-09 09:12, Mcnamara, John: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Xuelin Shi > > Yes, the patch http://dpdk.org/dev/patchwork/patch/3132/ should be > > abandoned. > > If you register and login to the DPDK patchwork site you can mark the patch > as "Not Applicable" or what

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-09 Thread Bruce Richardson
On Wed, Mar 04, 2015 at 02:34:12PM +0800, xuelin.shi at freescale.com wrote: > From: Xuelin Shi > > This module uses type conversion between struct and int. > Also truncation and comparison is used with this int. > It is not safe for different endian arch. > > Add ifdef for big endian struct to

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-09 Thread Xuelin Shi
dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely > for big endian > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Xuelin Shi > > Sent: Monday, March 9, 2015 1:54 AM > > To: Richardson, Bruce > > Cc: dev at dpdk.org

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Xuelin Shi > Sent: Monday, March 9, 2015 1:54 AM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for > big endian &g

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-09 Thread Xuelin Shi
Hi Bruce, Yes, the patch http://dpdk.org/dev/patchwork/patch/3132/ should be abandoned. Thanks, Shi xuelin > -Original Message- > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > Sent: Friday, March 06, 2015 19:14 > To: Shi Xuelin-B29237 > Cc: thomas.monjalon at 6wind.com;

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-06 Thread Bruce Richardson
On Thu, Mar 05, 2015 at 02:12:12AM +, Xuelin Shi wrote: > Hi Bruce, > > Yes, it needs to swap the fields. The bit field is first identified as the > uint8_t and then packed. > > Thanks, > Shi xuelin > Am I right in thinking that this patch set supercedes that for "lpm: use field access inst

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-05 Thread Xuelin Shi
Hi Bruce, Yes, it needs to swap the fields. The bit field is first identified as the uint8_t and then packed. Thanks, Shi xuelin > -Original Message- > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > Sent: Wednesday, March 04, 2015 18:48 > To: Shi Xuelin-B29237 > Cc: tho

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-04 Thread xuelin....@freescale.com
From: Xuelin Shi This module uses type conversion between struct and int. Also truncation and comparison is used with this int. It is not safe for different endian arch. Add ifdef for big endian struct to fix this issue. Signed-off-by: Xuelin Shi --- lib/librte_lpm/rte_lpm.h | 19

[dpdk-dev] [PATCH] librte_lpm: define tbl entry reversely for big endian

2015-03-04 Thread Bruce Richardson
On Wed, Mar 04, 2015 at 02:34:12PM +0800, xuelin.shi at freescale.com wrote: > From: Xuelin Shi > > This module uses type conversion between struct and int. > Also truncation and comparison is used with this int. > It is not safe for different endian arch. > > Add ifdef for big endian struct to