lto:jons...@cisco.com>>
Cc: "dev@dpdk.org<mailto:dev@dpdk.org>" mailto:dev@dpdk.org>>,
"ferruh.yi...@intel.com<mailto:ferruh.yi...@intel.com>"
mailto:ferruh.yi...@intel.com>>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC address
gt; *From: *Igor Ryzhov
> *Date: *Thursday, January 19, 2017 at 2:39 PM
> *To: *Steve Shin
> *Cc: *"dev@dpdk.org" , "ferruh.yi...@intel.com" <
> ferruh.yi...@intel.com>
> *Subject: *Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on MAC
> address
l_sel[0] = 1;
+
return 0;
Any thoughts would be appreciated.
Regards,
Steve
From: Igor Ryzhov
Date: Thursday, January 19, 2017 at 2:39 PM
To: Steve Shin
Cc: "dev@dpdk.org" , "ferruh.yi...@intel.com"
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: error handling on
Hello Steve,
Thank you for the patch.
I think a couple of improvements can be done:
1. Function existence check – if (*dev->dev_ops->mac_addr_add) – can be
taken out of the loop. We don't need to check it on each iteration.
2. I'm not completely sure, but I think loop can be started from 1, not
f
Dear maintainer,
Sorry that I forgot to add “Fixes:” line as follows:
Fixes: 4bdefaade6d1 ("ethdev: VMDQ enhancements")
Can you please add the above line as part of comment?
Thanks,
Steve
On 1/19/17, 10:47 AM, "Steve Shin (jonshin)" wrote:
This patch fixes a bug in replaying MAC
This patch fixes a bug in replaying MAC address to the hardware
in rte_eth_dev_config_restore() routine.
Signed-off-by: Steve Shin
---
lib/librte_ether/rte_ethdev.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte
6 matches
Mail list logo
