Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-03 Thread Bruce Richardson
On Tue, Dec 03, 2019 at 01:33:19PM +0800, Ye Xiaolong wrote: > On 12/02, Bruce Richardson wrote: > >On Mon, Dec 02, 2019 at 07:34:54PM +0800, Ye Xiaolong wrote: > >> On 12/02, Igor Ryzhov wrote: > >> >We should at least install it into /lib/modules/kernel-version. For > >> >convenience, dpdk module

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Ye Xiaolong
On 12/02, Bruce Richardson wrote: >On Mon, Dec 02, 2019 at 07:34:54PM +0800, Ye Xiaolong wrote: >> On 12/02, Igor Ryzhov wrote: >> >We should at least install it into /lib/modules/kernel-version. For >> >convenience, dpdk modules are installed into >> >/lib/modules/kernel-version/extra/dpdk. >> >In

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Ye Xiaolong
On 12/02, Bruce Richardson wrote: >On Mon, Dec 02, 2019 at 07:34:54PM +0800, Ye Xiaolong wrote: >> On 12/02, Igor Ryzhov wrote: >> >We should at least install it into /lib/modules/kernel-version. For >> >convenience, dpdk modules are installed into >> >/lib/modules/kernel-version/extra/dpdk. >> >In

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Bruce Richardson
On Mon, Dec 02, 2019 at 07:34:54PM +0800, Ye Xiaolong wrote: > On 12/02, Igor Ryzhov wrote: > >We should at least install it into /lib/modules/kernel-version. For > >convenience, dpdk modules are installed into > >/lib/modules/kernel-version/extra/dpdk. > >In the cross-compilation case, you can use

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Ye Xiaolong
On 12/02, Igor Ryzhov wrote: >We should at least install it into /lib/modules/kernel-version. For >convenience, dpdk modules are installed into >/lib/modules/kernel-version/extra/dpdk. >In the cross-compilation case, you can use DEST_DIR to set some prefix. > >I don't really see the issue here. The

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Igor Ryzhov
We should at least install it into /lib/modules/kernel-version. For convenience, dpdk modules are installed into /lib/modules/kernel-version/extra/dpdk. In the cross-compilation case, you can use DEST_DIR to set some prefix. I don't really see the issue here. The description clearly says that head

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Ye Xiaolong
Hi, Igor Thanks for the feedback. On 12/02, Igor Ryzhov wrote: >Hi Xiaolong, > >Nack from me. It's just an incorrect revert of my fix. >Kernel modules will be installed in wrong directory, just check install_dir Is there any convention that we must install kernel modules to which directory? And

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Igor Ryzhov
Hi Xiaolong, Nack from me. It's just an incorrect revert of my fix. Kernel modules will be installed in wrong directory, just check install_dir parameter in kni/meson.build and igb_uio/meson.build. Igor On Mon, Dec 2, 2019 at 9:18 AM Xiaolong Ye wrote: > kernel_dir option in meson build is equ

[dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-01 Thread Xiaolong Ye
kernel_dir option in meson build is equivalent to RTE_KERNELDIR in make system, for cross-compilation case, users would specify it as local kernel src dir like //target-arm_glibc/linux-arm/linux-4.19.81/ Current meson build would fail to compile kernel module if user specify kernel_dir as above,