[dpdk-dev] [PATCH] ixgbe:Prevent redefinition of bool if compiling using c++

2016-07-22 Thread Thomas Monjalon
2016-07-18 13:39, Ido Barnea: > Signed-off-by: Ido Barnea Patch reconstructed (format was not applicable), and applied, thanks

[dpdk-dev] [PATCH] ixgbe:Prevent redefinition of bool if compiling using c++

2016-07-18 Thread Thomas Monjalon
2016-07-18 14:12, Ido Barnea: > In Trex, we do include ixgbe_type.h from c++ code because we do some > register writes ourselves to support some functionality not exposed in > the DPDK API. I agree we should find a way to expose some driver-specific headers for very specific features which will ne

[dpdk-dev] [PATCH] ixgbe:Prevent redefinition of bool if compiling using c++

2016-07-18 Thread Thomas Monjalon
Hi, DPDK is a C code and do not support C++ compilation. Only the exposed headers have some C++ support requirements. > drivers/net/ixgbe/base/ixgbe_osdep.h | 2 ++ Patching this file for C++ will be probably rejected, sorry. I'm interested to understand what is your need?

[dpdk-dev] [PATCH] ixgbe:Prevent redefinition of bool if compiling using c++

2016-07-18 Thread Ido Barnea (ibarnea)
Actually, dozens of h files contain this code: #ifdef __cplusplus extern "C" { #endif Less common in drivers, but also exists. In Trex, we do include ixgbe_type.h from c++ code because we do some register writes ourselves to support some functionality not exposed in the DPDK API. We can continue

[dpdk-dev] [PATCH] ixgbe:Prevent redefinition of bool if compiling using c++

2016-07-18 Thread Ido Barnea (ibarnea)
Signed-off-by: Ido Barnea --- drivers/net/ixgbe/base/ixgbe_osdep.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h index 31cc1be..06d1ee1 100644 --- a/drivers/net/ixgbe/base/ixgbe_osdep.h +++ b/drivers/net/ixgbe/ba