On 09/06/15 16:44, Ananyev, Konstantin wrote:
>
>
>> -Original Message-
>> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org]
>> Sent: Tuesday, June 09, 2015 4:08 PM
>> To: Ananyev, Konstantin; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] ix
On 09/06/15 12:18, Ananyev, Konstantin wrote:
>
>
>> -Original Message-
>> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org]
>> Sent: Wednesday, June 03, 2015 6:47 PM
>> To: Ananyev, Konstantin; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] ix
> -Original Message-
> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org]
> Sent: Tuesday, June 09, 2015 4:08 PM
> To: Ananyev, Konstantin; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh
>
>
>
> On 09/06/15 12:18
> -Original Message-
> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org]
> Sent: Wednesday, June 03, 2015 6:47 PM
> To: Ananyev, Konstantin; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh
>
>
>
> On 02/06/15 18:35
On 02/06/15 18:35, Ananyev, Konstantin wrote:
>
>
>> -Original Message-
>> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org]
>> Sent: Tuesday, June 02, 2015 4:08 PM
>> To: Ananyev, Konstantin; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] ix
> -Original Message-
> From: Zoltan Kiss [mailto:zoltan.kiss at linaro.org]
> Sent: Tuesday, June 02, 2015 4:08 PM
> To: Ananyev, Konstantin; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh
>
>
>
> On 02/06/15 14:31
On 02/06/15 14:31, Ananyev, Konstantin wrote:
> Hi Zoltan,
>
>> -Original Message-
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zoltan Kiss
>> Sent: Monday, June 01, 2015 5:16 PM
>> To: dev at dpdk.org
>> Subject: Re: [dpdk-
Hi Zoltan,
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zoltan Kiss
> Sent: Monday, June 01, 2015 5:16 PM
> To: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh
>
> Hi,
>
> Anyone woul
Hi,
Anyone would like to review this patch? Venky sent a NAK, but I've
explained to him why it is a bug.
Regards,
Zoltan
On 27/05/15 21:12, Zoltan Kiss wrote:
> This check doesn't do what's required by rte_eth_tx_burst:
> "When the number of previously sent packets reached the "minimum transmi
The requirements for rte_eth_tx_burst(), which calls a driver specific
function, in case of ixgbe, these two:
"It is the responsibility of the rte_eth_tx_burst() function to
transparently free the memory buffers of packets previously sent. This
feature is driven by the *tx_free_thresh* value su
NAK. This causes more (unsuccessful) cleanup attempts on the descriptor ring.
What is motivating this change?
Regards,
Venky
> On May 28, 2015, at 1:42 AM, Zoltan Kiss wrote:
>
> This check doesn't do what's required by rte_eth_tx_burst:
> "When the number of previously sent packets reached
This check doesn't do what's required by rte_eth_tx_burst:
"When the number of previously sent packets reached the "minimum transmit
packets to free" threshold"
This can cause problems when txq->tx_free_thresh + [number of elements in the
pool] < txq->nb_tx_desc.
Signed-off-by: Zoltan Kiss
---
12 matches
Mail list logo
