2015-11-30 11:54, Jingjing Wu:
> When dev_stop is called in i40evf pmd driver, queues are switched off
> to stop receiving and transmitting. But the mac address of this VF
> still exists in VEB switch.
> To stop the traffic from VSI level, the mac address need to be removed
> too. Then the bandwidt
2015-11-30 08:33, Stephen Hemminger:
> On Mon, 30 Nov 2015 11:54:09 +0800
> Jingjing Wu wrote:
>
> > + (void)rte_memcpy(mac_addr.addr_bytes, hw->mac.addr,
> > + sizeof(mac_addr.addr_bytes))
>
> Please don't add useless (void) cast.
> I haven't seen that since lint on
When dev_stop is called in i40evf pmd driver, queues are switched off
to stop receiving and transmitting. But the mac address of this VF
still exists in VEB switch.
To stop the traffic from VSI level, the mac address need to be removed
too. Then the bandwidth for this SRIOV VSI can be freed.
This p
On Mon, 30 Nov 2015 11:54:09 +0800
Jingjing Wu wrote:
> + (void)rte_memcpy(mac_addr.addr_bytes, hw->mac.addr,
> + sizeof(mac_addr.addr_bytes))
Please don't add useless (void) cast.
I haven't seen that since lint on Unix.
> > + /* Set mac addr */
> > + (void)rte_memcpy(mac_addr.addr_bytes, hw->mac.addr,
> > + sizeof(mac_addr.addr_bytes));
> Use ether_addr_copy() instead.
>
> /Helin
Thanks. But the types of mac_addr and hw->mac are different, cannot use
ether_addr_copy.
Thanks
Jingji
> -Original Message-
> From: Wu, Jingjing
> Sent: Monday, November 30, 2015 11:54 AM
> To: dev at dpdk.org
> Cc: Wu, Jingjing; Zhang, Helin; Pei, Yulong
> Subject: [PATCH] i40evf: fix mac deletion when stop dev
>
> When dev_stop is called in i40evf pmd driver, queues are switched off to
6 matches
Mail list logo
