2016-07-11 12:01, Jingjing Wu:
> move PCI device ids from rte_pci_dev_ids.h to driver.
>
> Signed-off-by: Jingjing Wu
Thanks
David has sent a v4 for almost every drivers, including i40e:
http://dpdk.org/ml/archives/dev/2016-July/043798.html
move PCI device ids from rte_pci_dev_ids.h to driver.
Signed-off-by: Jingjing Wu
---
drivers/net/i40e/i40e_ethdev.c | 21 ++--
drivers/net/i40e/i40e_ethdev_vf.c | 9 ++--
lib/librte_eal/common/include/rte_pci_dev_ids.h | 71 -
3 files c
Hi Helin,
2016-07-11 06:19, Zhang, Helin:
> Hi Jingjing
>
> I'd suggest to add a new header file in each PMD to define what we defined in
> rte_pci_dev_ids.h.
Why?
> There was a patch set submitted several months ago, like that.
Which one?
> -Original Message-
> From: Wu, Jingjing
> Sent: Monday, July 11, 2016 3:29 PM
> To: Zhang, Helin ; Thomas Monjalon
>
> Cc: dev at dpdk.org
> Subject: RE: [PATCH] i40e: move PCI device ids to driver
>
> Hi, helin
>
> What I did is exactly same as what David's patch set did in i40e. I
Hi, helin
What I did is exactly same as what David's patch set did in i40e. I agree with
his change.
About the new header file, there is already i40e_devids.h in base code which
defines the device IDs and vendor ID. This patch just combines them to be a pci
device id in struct pci_id_i40e_map i
Hi Thomas
It should be the one from David as I read that before. I am not sure if all PMD
has its own header files for device IDs, but I did see there was.
Even in recent kernel drivers (e.g. i40e), there is a new header file for
device ID list. I think it could be clearer, though no correct or
Hi Jingjing
I'd suggest to add a new header file in each PMD to define what we defined in
rte_pci_dev_ids.h.
There was a patch set submitted several months ago, like that.
Regards,
Helin
> -Original Message-
> From: Wu, Jingjing
> Sent: Monday, July 11, 2016 12:01 PM
> To: thomas.monjal
7 matches
Mail list logo
