Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-09-11 Thread Xing, Beilei
> -Original Message- > From: David Harton (dharton) [mailto:dhar...@cisco.com] > Sent: Tuesday, September 12, 2017 1:23 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast > addresses > > Hi Beilei, > > > ---

Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-09-11 Thread David Harton (dharton)
Hi Beilei, > -Original Message- > From: Xing, Beilei [mailto:beilei.x...@intel.com] > > Hi, > > > -Original Message- > > From: David Harton [mailto:dhar...@cisco.com] > > > > The i40e maintains a single MAC filter table for both unicast and > > multicast addresses. The i40e_vali

Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-09-10 Thread Xing, Beilei
Hi, > -Original Message- > From: David Harton [mailto:dhar...@cisco.com] > Sent: Wednesday, August 23, 2017 6:22 AM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; David Harton > Subject: [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast > addresses > > The i40e maintai

Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-09-08 Thread Ferruh Yigit
On 9/8/2017 1:51 PM, David Harton (dharton) wrote: > Hi Jingjing/Beilei, > > A kind reminder to review the patch and the discussion between > Ferruh and myself. Hi David, To clarify, your reply answered my concern, so I am OK, still I believe this should be reviewed by driver maintainer. Thank

Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-09-08 Thread David Harton (dharton)
Hi Jingjing/Beilei, A kind reminder to review the patch and the discussion between Ferruh and myself. Thanks, Dave > -Original Message- > From: David Harton (dharton) > > -Original Message- > > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > > > On 8/22/2017 11:21 PM, Dav

Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-08-31 Thread David Harton (dharton)
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, August 31, 2017 11:54 AM > To: David Harton (dharton) ; jingjing...@intel.com; > beilei.x...@intel.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40e: fix i40e

Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-08-31 Thread Ferruh Yigit
On 8/22/2017 11:21 PM, David Harton wrote: > The i40e maintains a single MAC filter table for both > unicast and multicast addresses. The i40e_validate_mac_addr > function was preventing multicast addresses from being added > to the table via i40evf_add_mac_addr. Fixed the issue by > removing the

[dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses

2017-08-22 Thread David Harton
The i40e maintains a single MAC filter table for both unicast and multicast addresses. The i40e_validate_mac_addr function was preventing multicast addresses from being added to the table via i40evf_add_mac_addr. Fixed the issue by removing the multicast address check in i40e_validate_mac_addr.