Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-13 Thread Thomas Monjalon
13/07/2018 22:20, Honnappa Nagarahalli: > Hi Pablo, > Thank you for your response. I recently noticed this macro > 'RTE_BUILD_BUG_ON'. Does it make sense to use this macro instead (though the > error message will be more cryptic)? Yes, I've hesitated to suggest RTE_BUILD_BUG_ON, but decided to p

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-13 Thread Honnappa Nagarahalli
2018 3:05 AM To: Thomas Monjalon ; Richardson, Bruce Cc: dev@dpdk.org; Honnappa Nagarahalli Subject: RE: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 12

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-12 Thread Thomas Monjalon
12/07/2018 10:05, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Review please? > > > > 31/05/2018 17:30, Honnappa Nagarahalli: > > > Validate RTE_HASH_BUCKET_ENTRIES during compilation instead of run > > > time. > > > > > > Signed-off-by: Honnappa Nagarahalli

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 12, 2018 8:42 AM > To: Richardson, Bruce ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Honnappa Nagarahalli > Subject: Re: [dpdk-dev] [PATCH] hash: validate hash

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-12 Thread Thomas Monjalon
Review please? 31/05/2018 17:30, Honnappa Nagarahalli: > Validate RTE_HASH_BUCKET_ENTRIES during compilation instead of > run time. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Gavin Hu > --- > lib/librte_eal/common/include/rte_common.h | 5 + > lib/librte_hash/rte_cuckoo_hash.c

[dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-05-31 Thread Honnappa Nagarahalli
Validate RTE_HASH_BUCKET_ENTRIES during compilation instead of run time. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- lib/librte_eal/common/include/rte_common.h | 5 + lib/librte_hash/rte_cuckoo_hash.c | 1 - lib/librte_hash/rte_cuckoo_hash.h | 4 3 f