Re: [dpdk-dev] [PATCH] fix static variables

2018-10-11 Thread Xing, Beilei
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, October 4, 2018 11:41 AM > To: Pattan, Reshma ; Hemant Agrawal > ; Shreyansh Jain ; > Ashish Gupta ; Trahe, Fiona > ; De Lara Guarch, Pablo > ; Akhil Goyal ; > Doherty, Declan ; Zhang, Roy Fan > ; Jerin Jacob ; > Chas Williams

Re: [dpdk-dev] [PATCH] fix static variables

2018-10-09 Thread Zhang, Tianfei
> diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > b/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > index f0939dc32..848e5183a 100644 > --- a/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > +++ b/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > @@ -104,14 +104,14 @@ static struc

Re: [dpdk-dev] [PATCH] fix static variables

2018-10-05 Thread Rao, Nikhil
On 10/4/2018 9:10 AM, Ferruh Yigit wrote: Make variables static as much as possible. For the ones can't be done static, prefix the variable name with component name. Also some cleanup and fix done related static usage while around. Signed-off-by: Ferruh Yigit --- app/pdump/main.c

[dpdk-dev] [PATCH] fix static variables

2018-10-03 Thread Ferruh Yigit
Make variables static as much as possible. For the ones can't be done static, prefix the variable name with component name. Also some cleanup and fix done related static usage while around. Signed-off-by: Ferruh Yigit --- app/pdump/main.c | 6 +-- drivers/bus/dpaa