Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-04-07 Thread Timothy M. Redaelli
On 02/17/2017 05:11 PM, remy.horton at intel.com (Remy Horton) wrote: > > On 16/02/2017 16:17, Markos Chandras wrote: >> The librte_ethtool library depends on librte_pmd_ixgbe if that >> pmd driver is enabled so we need to link against it when we compile >> the ethtool application. It fixes the fo

Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-04-04 Thread Remy Horton
On 04/04/2017 11:15, Thomas Monjalon wrote: Ping [..] --- a/examples/ethtool/ethtool-app/Makefile +++ b/examples/ethtool/ethtool-app/Makefile +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) +LDLIBS += -lrte_pmd_ixgbe +endif Please, could you confirm we can remove the same LDLIBS line from examples/

Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-04-04 Thread Thomas Monjalon
Ping 2017-03-09 21:13, Thomas Monjalon: > 2017-02-16 16:17, Markos Chandras: > > The librte_ethtool library depends on librte_pmd_ixgbe if that > > pmd driver is enabled so we need to link against it when we compile > > the ethtool application. It fixes the following build problem: > > > > /usr/l

Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-03-09 Thread Thomas Monjalon
2017-02-16 16:17, Markos Chandras: > The librte_ethtool library depends on librte_pmd_ixgbe if that > pmd driver is enabled so we need to link against it when we compile > the ethtool application. It fixes the following build problem: > > /usr/lib64/gcc/x86_64-suse-linux/6/../../../../x86_64-suse-

Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-02-20 Thread Remy Horton
On 16/02/2017 16:17, Markos Chandras wrote: [..] Cc: Nirmoy Das Signed-off-by: Markos Chandras Acked-by: Remy Horton

Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-02-20 Thread Remy Horton
On 17/02/2017 16:27, Markos Chandras wrote: On 02/17/2017 04:11 PM, Remy Horton wrote: [..] Yeah I am seen this problem in the openSUSE Tumbleweed distribution. I think Nirmoy may have seen that in openSUSE Leap but I will let him confirm that. Tried Tumbleweed (version 13.3 I think) but hav

Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-02-17 Thread Markos Chandras
On 02/17/2017 04:11 PM, Remy Horton wrote: > > On 16/02/2017 16:17, Markos Chandras wrote: >> The librte_ethtool library depends on librte_pmd_ixgbe if that >> pmd driver is enabled so we need to link against it when we compile >> the ethtool application. It fixes the following build problem: > >

Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-02-17 Thread Remy Horton
On 16/02/2017 16:17, Markos Chandras wrote: The librte_ethtool library depends on librte_pmd_ixgbe if that pmd driver is enabled so we need to link against it when we compile the ethtool application. It fixes the following build problem: For some reason this is not an issue with my Fedora box,

[dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-02-16 Thread Markos Chandras
The librte_ethtool library depends on librte_pmd_ixgbe if that pmd driver is enabled so we need to link against it when we compile the ethtool application. It fixes the following build problem: /usr/lib64/gcc/x86_64-suse-linux/6/../../../../x86_64-suse-linux/bin/ld: warning: librte_pmd_ixgbe.so.1,