Re: [dpdk-dev] [PATCH] examples/vhost_scsi: replace strncpy with strlcpy

2018-05-10 Thread Pattan, Reshma
Hi Bruce, > Can the magic numbers "32", "8", "4" be replaced with non-magic values, e.g. > sizeof(...). > This is now taken care wherever possible in latest patch. Thanks, Reshma > /Bruce

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: replace strncpy with strlcpy

2018-05-09 Thread Pattan, Reshma
Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Wednesday, May 9, 2018 2:37 PM > To: Pattan, Reshma > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/vhost_scsi: replace strncpy with > strlcpy > > On Wed, May 0

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: replace strncpy with strlcpy

2018-05-09 Thread Bruce Richardson
On Wed, May 09, 2018 at 12:35:29PM +0100, Reshma Pattan wrote: > Use strlcpy instead of strncpy. > > Fixes: db75c7af19 ("examples/vhost_scsi: introduce a new sample app") > CC: sta...@dpdk.org > > Signed-off-by: Reshma Pattan > --- > examples/vhost_scsi/scsi.c | 11 ++- > 1 file changed

[dpdk-dev] [PATCH] examples/vhost_scsi: replace strncpy with strlcpy

2018-05-09 Thread Reshma Pattan
Use strlcpy instead of strncpy. Fixes: db75c7af19 ("examples/vhost_scsi: introduce a new sample app") CC: sta...@dpdk.org Signed-off-by: Reshma Pattan --- examples/vhost_scsi/scsi.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/examples/vhost_scsi/scsi.c b/exam