Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Ananyev, Konstantin
> > --- > > I agree with Thomas, needs clearer description. Suggest using some of > the wording provided by Konstantin in later replies. Also, needs a > Fixes: tag and a CC: stable, because it appears that this bug has been > around for a few releases. Good point, I forgot about 'fixes' and 'st

Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Burakov, Anatoly
On 12-Nov-18 8:46 PM, Herakliusz Lipiec wrote: This example was dropping packets when using clone (ip 224.0.0.103). The problem was that mbufs were not freed. This was caused by coping ol_flags from cloned mbuf to header mbufs. Signed-off-by: Herakliusz Lipiec --- I agree with Thomas, needs c

Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Ananyev, Konstantin
> > Hi, > > 12/11/2018 21:46, Herakliusz Lipiec: > > This example was dropping packets when using clone (ip 224.0.0.103). The problem is that ipv4_multicast app: 1. invokes rte_pktmbuf_clone() for the packet (that creates a new mbuf with IND_ATTACHED_MBUF set in ol_flags). 2. creates new mb

Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-13 Thread Thomas Monjalon
Hi, 12/11/2018 21:46, Herakliusz Lipiec: > This example was dropping packets when using clone (ip 224.0.0.103). What is this IP? What is clone? > The problem was that mbufs were not freed. This was caused by coping > ol_flags from cloned mbuf to header mbufs. Mbuf is not freed because of ol_fla

Re: [dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-12 Thread Ananyev, Konstantin
> -Original Message- > From: Lipiec, Herakliusz > Sent: Monday, November 12, 2018 8:47 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Lipiec, Herakliusz > > Subject: [PATCH] example/ipv4_multicast: fix app hanging when using clone > > This example was dropping packets when using cl

[dpdk-dev] [PATCH] example/ipv4_multicast: fix app hanging when using clone

2018-11-12 Thread Herakliusz Lipiec
This example was dropping packets when using clone (ip 224.0.0.103). The problem was that mbufs were not freed. This was caused by coping ol_flags from cloned mbuf to header mbufs. Signed-off-by: Herakliusz Lipiec --- examples/ipv4_multicast/main.c | 2 -- 1 file changed, 2 deletions(-) diff --