Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-08 Thread Andrew Rybchenko
Hi Matan, Many thanks for review. See below. Andrew. On 10/6/21 12:45 PM, Matan Azrad wrote: > Hi Andrew > > Thank you for the big effort to adjust mlx5. > I left some comments inside. > If you feel it is too much, we can do a later patch to improve. > > Matan > > >> From: Andrew Rybchenko >

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-06 Thread Ori Kam
Hi Andrew, > -Original Message- > From: dev On Behalf Of Andrew Rybchenko > Sent: Tuesday, September 28, 2021 6:23 PM > Subject: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter > attribute > > Indirect actions should be used to do shared counters. >

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-06 Thread Somnath Kotur
On Tue, Sep 28, 2021 at 8:53 PM Andrew Rybchenko wrote: > > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew Rybchenko > --- > app/test-pmd/cmdline_flow.c| 10 -- > doc/guides/prog_guide/rte_flow.rst | 19 +-- > doc/guides/rel_notes/depre

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-06 Thread Matan Azrad
Hi Andrew Thank you for the big effort to adjust mlx5. I left some comments inside. If you feel it is too much, we can do a later patch to improve. Matan > From: Andrew Rybchenko > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew Rybchenko > --- > app/test-pmd

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-05 Thread Ajit Khaparde
On Tue, Oct 5, 2021 at 12:11 PM Thomas Monjalon wrote: > 28/09/2021 17:23, Andrew Rybchenko: > > Indirect actions should be used to do shared counters. > > > > Signed-off-by: Andrew Rybchenko > > Acked-by: Thomas Monjalon > Acked-by: Ajit Khaparde > > Thanks Andrew, we need more maintainers

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-05 Thread Thomas Monjalon
28/09/2021 17:23, Andrew Rybchenko: > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew Rybchenko Acked-by: Thomas Monjalon Thanks Andrew, we need more maintainers like you :)

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-09-28 Thread Andrew Rybchenko
On 9/28/21 6:58 PM, Stephen Hemminger wrote: > On Tue, 28 Sep 2021 18:23:00 +0300 > Andrew Rybchenko wrote: > >> @@ -2498,24 +2498,11 @@ struct rte_flow_query_age { >> * Counters can be retrieved and reset through ``rte_flow_query()``, see >> * ``struct rte_flow_query_count``. >> * >> - * @

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-09-28 Thread Stephen Hemminger
On Tue, 28 Sep 2021 18:23:00 +0300 Andrew Rybchenko wrote: > @@ -2498,24 +2498,11 @@ struct rte_flow_query_age { > * Counters can be retrieved and reset through ``rte_flow_query()``, see > * ``struct rte_flow_query_count``. > * > - * @deprecated Shared attribute is deprecated, use generic >

[dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-09-28 Thread Andrew Rybchenko
Indirect actions should be used to do shared counters. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline_flow.c| 10 -- doc/guides/prog_guide/rte_flow.rst | 19 +-- doc/guides/rel_notes/deprecation.rst | 4 - doc/guides/rel_notes/release_21_11.rst |