Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-23 Thread Andrew Rybchenko
Subject: Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths Hi Aaron From: Aaron Conole Sent: Monday, July 23, 2018 2:52 PM To: Matan Azrad Cc: dev@dpdk.org; Ferruh Yigit ; Marcelo Leitner ; Shahaf Shuler ; Ori Kam ; Thomas Monjalon Subject: Re: [dpdk-dev] [PATCH] ethdev: move

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-23 Thread Ananyev, Konstantin
ject: Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths > > > Hi Aaron > From: Aaron Conole > > Sent: Monday, July 23, 2018 2:52 PM > > To: Matan Azrad > > Cc: dev@dpdk.org; Ferruh Yigit ; Marcelo Leitner > > ; Shahaf Shuler ; Ori Kam > >

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-23 Thread Matan Azrad
Hi Aaron From: Aaron Conole > Sent: Monday, July 23, 2018 2:52 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ferruh Yigit ; Marcelo Leitner > ; Shahaf Shuler ; Ori Kam > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths >

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-23 Thread Aaron Conole
Matan Azrad writes: > Hi Aaron > > From: Aaron Conole >> These checks would have prevented a reported crash in the field. If a user >> builds without ETHDEV_DEBUG, it should make their application more stable, >> not less. >> >> Many of these functions immediately dereference arrays based on th

Re: [dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-22 Thread Matan Azrad
Hi Aaron From: Aaron Conole > These checks would have prevented a reported crash in the field. If a user > builds without ETHDEV_DEBUG, it should make their application more stable, > not less. > > Many of these functions immediately dereference arrays based on the passed > in values, so the san

[dpdk-dev] [PATCH] ethdev: move sanity checks to non-debug paths

2018-07-22 Thread Aaron Conole
These checks would have prevented a reported crash in the field. If a user builds without ETHDEV_DEBUG, it should make their application more stable, not less. Many of these functions immediately dereference arrays based on the passed in values, so the sanity checks are quite important. The logs