Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

2018-09-28 Thread Li, Xiaoyun
; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd In general, an API is less error prone if it only does return by value. What about just returning fd or -1? On Fri, Sep 28, 2018, 5:55 AM Xiaoyun Li mailto:xiaoyun...@intel.com>> wrote: Some users want to use the

Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

2018-09-28 Thread Stephen Hemminger
In general, an API is less error prone if it only does return by value. What about just returning fd or -1? On Fri, Sep 28, 2018, 5:55 AM Xiaoyun Li wrote: > Some users want to use their own epoll instances to control both > DPDK rxq interrupt fds and their own other fds. So added a function >

Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

2018-09-28 Thread Li, Xiaoyun
OK. Thanks. > -Original Message- > From: Yigit, Ferruh > Sent: Friday, September 28, 2018 16:33 > To: Li, Xiaoyun ; tho...@monjalon.net; Zhang, Helin > ; damar...@cisco.com; Kinsella, Ray > ; dev@dpdk.org > Subject: Re: [PATCH] ethdev: get rxq interrupt fd > > On 9/28/2018 4:43 AM, Xiaoyu

Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

2018-09-28 Thread Ferruh Yigit
On 9/28/2018 4:43 AM, Xiaoyun Li wrote: > Some users want to use their own epoll instances to control both > DPDK rxq interrupt fds and their own other fds. So added a function > to get rxq interrupt fd based on port id and queue id. > > Signed-off-by: Xiaoyun Li <...> > @@ -2719,6 +2719,9 @@ i

[dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

2018-09-27 Thread Xiaoyun Li
Some users want to use their own epoll instances to control both DPDK rxq interrupt fds and their own other fds. So added a function to get rxq interrupt fd based on port id and queue id. Signed-off-by: Xiaoyun Li --- lib/librte_ethdev/rte_ethdev.c | 37 ++ lib/li