Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit

2018-11-19 Thread Stephen Hemminger
On Mon, 19 Nov 2018 08:38:44 + Leah Tekoa wrote: > - link = dev->data->dev_link; > + memcpy(&link, &dev->data->dev_link, sizeof(struct rte_eth_link)); > If structure assignment and memcpy don't give same result, then you have a buggy compiler.

Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit

2018-11-19 Thread Leah Tekoa
bject: Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit On 11/19/2018 8:38 AM, Leah Tekoa wrote: > From: Leah Tekoa > > memcpy should be used for copying rte_eth_link structure Why? > > Fixes: 8dbe82b0 ("ethdev: Tx rate limitation for queue an

Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit

2018-11-19 Thread Ferruh Yigit
On 11/19/2018 8:38 AM, Leah Tekoa wrote: > From: Leah Tekoa > > memcpy should be used for copying rte_eth_link structure Why? > > Fixes: 8dbe82b0 ("ethdev: Tx rate limitation for queue and VF") > > Signed-off-by: Leah Tekoa > --- > lib/librte_ethdev/rte_ethdev.c | 2 +- > 1 file changed, 1

[dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit

2018-11-19 Thread Leah Tekoa
From: Leah Tekoa memcpy should be used for copying rte_eth_link structure Fixes: 8dbe82b0 ("ethdev: Tx rate limitation for queue and VF") Signed-off-by: Leah Tekoa --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethd