On 5/2/2018 6:09 PM, Shahaf Shuler wrote:
> Wednesday, May 2, 2018 1:06 PM, Thomas Monjalon:
>> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure
>>
>> 02/05/2018 11:58, Xueming(Steven) Li:
>>> From: Ferruh Yigit
>>>> Or as Xu
Wednesday, May 2, 2018 1:06 PM, Thomas Monjalon:
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure
>
> 02/05/2018 11:58, Xueming(Steven) Li:
> > From: Ferruh Yigit
> > > Or as Xueming suggested, we can take rss_hf config as best effort and
&
02/05/2018 11:58, Xueming(Steven) Li:
> From: Ferruh Yigit
> > Or as Xueming suggested, we can take rss_hf config as best effort and not
> > return error at all.
> >
> > I think this forces PMDs to have up-to-date flow_type_rss_offloads values,
> > is there any other benefit?
> > What was the i
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, May 1, 2018 10:32 PM
> To: Thomas Monjalon
> Cc: Xueming(Steven) Li ; dev@dpdk.org
> Subject: Re: [PATCH] ethdev: fix applications failure on configure
>
> On 5/1/2018 3:12 PM, Thomas Monjalon wrote:
> > 01/05/2018 16:08, Ferru
01/05/2018 17:30, Thomas Monjalon:
> 01/05/2018 15:33, Ferruh Yigit:
> > Many sample applications fail because of
> > dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
> >
> > The sample applications need to be fixed/updated before returning error
> > on rte_eth_dev_configure()
> >
01/05/2018 15:33, Ferruh Yigit:
> Many sample applications fail because of
> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
>
> The sample applications need to be fixed/updated before returning error
> on rte_eth_dev_configure()
>
> This patch keeps the error log but removes ret
On 5/1/2018 3:12 PM, Thomas Monjalon wrote:
> 01/05/2018 16:08, Ferruh Yigit:
>> On 5/1/2018 3:01 PM, Thomas Monjalon wrote:
>>> 01/05/2018 15:33, Ferruh Yigit:
Many sample applications fail because of
dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
>>>
>>> We need to def
01/05/2018 16:08, Ferruh Yigit:
> On 5/1/2018 3:01 PM, Thomas Monjalon wrote:
> > 01/05/2018 15:33, Ferruh Yigit:
> >> Many sample applications fail because of
> >> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
> >
> > We need to define the API behaviour in doxygen.
> >
> >> Th
On 5/1/2018 3:01 PM, Thomas Monjalon wrote:
> 01/05/2018 15:33, Ferruh Yigit:
>> Many sample applications fail because of
>> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
>
> We need to define the API behaviour in doxygen.
>
>> The sample applications need to be fixed/updated b
01/05/2018 15:33, Ferruh Yigit:
> Many sample applications fail because of
> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
We need to define the API behaviour in doxygen.
> The sample applications need to be fixed/updated before returning error
> on rte_eth_dev_configure()
>
>
Looks good, thanks.
How do you think rss_hf, normally people think it best effort.
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, May 1, 2018 9:34 PM
> To: Thomas Monjalon
> Cc: dev@dpdk.org; Ferruh Yigit ; Xueming(Steven) Li
>
> Subject: [PATCH] ethdev: fix applications f
Many sample applications fail because of
dev_info.flow_type_rss_offloads check in rte_eth_dev_configure()
The sample applications need to be fixed/updated before returning error
on rte_eth_dev_configure()
This patch keeps the error log but removes returning error.
Fixes: 8863a1fbfc66 ("ethdev: a
12 matches
Mail list logo
