Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-11 Thread Ori Kam
Hi, Small answer update to make the example more clear. (adding the mask to the item, in previous mail I assumed it is clear that the mask is on only for the selected bits, but since it may not be clear I'm adding the mask in use) In any case since RC1 is around the corner, I'm going to send V

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-11 Thread Ajit Khaparde
On Thu, Apr 8, 2021 at 12:44 AM Jerin Jacob wrote: > > On Thu, Apr 8, 2021 at 3:45 AM Ori Kam wrote: > > > > Hi Jerin, > > > > > -Original Message- > > > From: Jerin Jacob > > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integ

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-10 Thread Ori Kam
Hi Andrew, PSB, Best, Ori > -Original Message- > From: Andrew Rybchenko > > On 4/8/21 2:39 PM, Ori Kam wrote: > > Hi Andrew, > > > > Thanks for your comments. > > > > PSB, > > > > Best, > > Ori > > > >> -Original Message- > >> From: Andrew Rybchenko > >> Sent: Thursday, April 8

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-10 Thread Ori Kam
> > > > > > -Original Message----- > > > > From: Jerin Jacob > > > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks > > > > > > > > On Wed, Apr 7, 2021 at 4:02 PM Ori Kam wrote: > > > > > >

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-09 Thread Andrew Rybchenko
On 4/8/21 2:39 PM, Ori Kam wrote: > Hi Andrew, > > Thanks for your comments. > > PSB, > > Best, > Ori > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Thursday, April 8, 2021 11:05 AM >> Subject: Re: [PATCH] ethdev: add packet integrity checks >> >> On 4/5/21 9:04 PM, Ori Kam

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-08 Thread Ori Kam
Hi Andrew, Thanks for your comments. PSB, Best, Ori > -Original Message- > From: Andrew Rybchenko > Sent: Thursday, April 8, 2021 11:05 AM > Subject: Re: [PATCH] ethdev: add packet integrity checks > > On 4/5/21 9:04 PM, Ori Kam wrote: > > Currently, DPDK application can offload the c

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-08 Thread Andrew Rybchenko
On 4/5/21 9:04 PM, Ori Kam wrote: > Currently, DPDK application can offload the checksum check, > and report it in the mbuf. > > However, as more and more applications are offloading some or all > logic and action to the HW, there is a need to check the packet > integrity so the right decision can

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-08 Thread Jerin Jacob
On Thu, Apr 8, 2021 at 3:45 AM Ori Kam wrote: > > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks > > > > On Wed, Apr 7, 2021 at 4:02 PM Ori Kam wrot

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-07 Thread Ori Kam
Hi Jerin, > -Original Message- > From: Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks > > On Wed, Apr 7, 2021 at 4:02 PM Ori Kam wrote: > > > > Hi Jerin, > > Hi Ori, > > > > > > > -Ori

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-07 Thread Jerin Jacob
On Wed, Apr 7, 2021 at 4:02 PM Ori Kam wrote: > > Hi Jerin, Hi Ori, > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, April 6, 2021 10:40 AM > > To: Ori Kam > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-07 Thread Ori Kam
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Tuesday, April 6, 2021 10:40 AM > To: Ori Kam > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks > > On Mon, Apr 5, 2021 at 11:35 PM Ori Kam wrote: > > > > Currently,

Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-06 Thread Jerin Jacob
On Mon, Apr 5, 2021 at 11:35 PM Ori Kam wrote: > > Currently, DPDK application can offload the checksum check, > and report it in the mbuf. > > However, as more and more applications are offloading some or all > logic and action to the HW, there is a need to check the packet > integrity so the rig

[dpdk-dev] [PATCH] ethdev: add packet integrity checks

2021-04-05 Thread Ori Kam
Currently, DPDK application can offload the checksum check, and report it in the mbuf. However, as more and more applications are offloading some or all logic and action to the HW, there is a need to check the packet integrity so the right decision can be taken. The application logic can be posit