> -Original Message-
> From: Gonzalez Monroy, Sergio
> Sent: Thursday, July 21, 2016 4:37 PM
> To: Jastrzebski, MichalX K ; Richardson,
> Bruce
> Cc: dev at dpdk.org; Kobylinski, MichalX ;
> david.marchand at 6wind.com
> Subject: Re: [PATCH] eal: fix check number of bytes from read functio
2016-07-21 20:50, Jastrzebski, MichalX K:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > - (int)sizeof(uint64_t) can be replaced by 8 but it's shorter ;)
>
> I didn't want to change all invokes of read() function here.
> I can use some macro:
> #define PFN_MASK_SIZE 8
> How do
ind.com
> Subject: Re: [dpdk-dev] [PATCH] eal: fix check number of bytes from read
> function
>
> Hi,
>
> 2016-07-20 16:24, Michal Jastrzebski:
> > - if (read(fd, &page, sizeof(uint64_t)) < 0) {
> > +
> > + retval = read(fd, &page, sizeof(uint64_
Hi,
2016-07-20 16:24, Michal Jastrzebski:
> - if (read(fd, &page, sizeof(uint64_t)) < 0) {
> +
> + retval = read(fd, &page, sizeof(uint64_t));
> + if (retval < 0) {
> RTE_LOG(ERR, EAL, "%s(): cannot read /proc/self/pagemap: %s\n",
> __func__,
On 20/07/2016 15:24, Michal Jastrzebski wrote:
> In rte_mem_virt2phy: Value returned from a function and indicating the
> number of bytes was ignored. This could cause a wrong pfn (page frame
> number) mask read from pagemap file.
> When read returns less than the number of sizeof(uint64_t) bytes,
In rte_mem_virt2phy: Value returned from a function and indicating the
number of bytes was ignored. This could cause a wrong pfn (page frame
number) mask read from pagemap file.
When read returns less than the number of sizeof(uint64_t) bytes,
function rte_mem_virt2phy returns error.
Coverity issu
6 matches
Mail list logo
