Re: [dpdk-dev] [PATCH] eal: cleanup strerror function

2017-10-05 Thread Thomas Monjalon
> > When compiled on Ubuntu with extra warnings enabled, the rte_strerror() > > function triggered a warning about an unused return value from > > strerror_r(). Rather than always have this warning disabled, we fix this, > > and in the process do some cleanup of the code so as to reduce the > > com

Re: [dpdk-dev] [PATCH] eal: cleanup strerror function

2017-09-15 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, September 7, 2017 2:10 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH] eal: cleanup strerror function > > When compiled on Ubuntu with extra warnings enab

Re: [dpdk-dev] [PATCH] eal: cleanup strerror function

2017-09-08 Thread Bruce Richardson
On Thu, Sep 07, 2017 at 10:51:52AM -0700, Stephen Hemminger wrote: > On Thu, 7 Sep 2017 14:09:56 +0100 > Bruce Richardson wrote: > > > + /* BSD puts a colon in the "unknown error" messages, Linux doesn't */ > > +#ifdef RTE_EXEC_ENV_BSDAPP > > + static const char *sep = ":"; > > +#else > > +

Re: [dpdk-dev] [PATCH] eal: cleanup strerror function

2017-09-07 Thread Stephen Hemminger
On Thu, 7 Sep 2017 14:09:56 +0100 Bruce Richardson wrote: > + /* BSD puts a colon in the "unknown error" messages, Linux doesn't */ > +#ifdef RTE_EXEC_ENV_BSDAPP > + static const char *sep = ":"; > +#else > + static const char *sep = ""; > +#endif This is seems unnecessary to me jus

[dpdk-dev] [PATCH] eal: cleanup strerror function

2017-09-07 Thread Bruce Richardson
When compiled on Ubuntu with extra warnings enabled, the rte_strerror() function triggered a warning about an unused return value from strerror_r(). Rather than always have this warning disabled, we fix this, and in the process do some cleanup of the code so as to reduce the complexity of the fix,