Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-10-05 Thread Thomas Monjalon
02/10/2020 14:12, Burakov, Anatoly: > On 02-Oct-20 10:36 AM, David Marchand wrote: > > On Thu, Sep 17, 2020 at 4:47 PM David Marchand > > wrote: > >> > >> On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly > >> wrote: > >>> Anonymous hugepages shouldn't matter, yes, but single-file segments mode >

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-10-02 Thread Burakov, Anatoly
On 02-Oct-20 10:36 AM, David Marchand wrote: On Thu, Sep 17, 2020 at 4:47 PM David Marchand wrote: On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly wrote: Anonymous hugepages shouldn't matter, yes, but single-file segments mode does fallocate() and remove - you have the remove part covered,

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-10-02 Thread David Marchand
On Thu, Sep 17, 2020 at 4:47 PM David Marchand wrote: > > On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly > wrote: > > Anonymous hugepages shouldn't matter, yes, but single-file segments mode > > does fallocate() and remove - you have the remove part covered, but i'm > > just curious if fallocat

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-17 Thread David Marchand
On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly wrote: > Anonymous hugepages shouldn't matter, yes, but single-file segments mode > does fallocate() and remove - you have the remove part covered, but i'm > just curious if fallocate() would also cause any issues with SELinux. I found no hook in t

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-17 Thread Aaron Conole
"Burakov, Anatoly" writes: > On 17-Sep-20 2:47 PM, David Marchand wrote: >> On Fri, Sep 11, 2020 at 2:46 PM Burakov, Anatoly >> wrote: Removing hugepage files is done in multiple places and the memory allocation code is complex. This fix tries to do the minimum and avoids touching

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 2:47 PM, David Marchand wrote: On Fri, Sep 11, 2020 at 2:46 PM Burakov, Anatoly wrote: Removing hugepage files is done in multiple places and the memory allocation code is complex. This fix tries to do the minimum and avoids touching other paths. If trying to remove the hugepage f

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-17 Thread David Marchand
On Fri, Sep 11, 2020 at 2:46 PM Burakov, Anatoly wrote: > > Removing hugepage files is done in multiple places and the memory > > allocation code is complex. > > This fix tries to do the minimum and avoids touching other paths. > > > > If trying to remove the hugepage file before allocating a page

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-11 Thread Burakov, Anatoly
On 10-Sep-20 5:24 PM, David Marchand wrote: This is something we encountered while working in an OpenShift environment with SELinux enabled. In this environment, a DPDK application could create/write to hugepage files but removing them was refused. This resulted in dirty files being reused when s

[dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-09-10 Thread David Marchand
This is something we encountered while working in an OpenShift environment with SELinux enabled. In this environment, a DPDK application could create/write to hugepage files but removing them was refused. This resulted in dirty files being reused when starting a new DPDK application and triggered r