[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

Hi Bruce, On 06/27/2016 03:39 PM, Bruce Richardson wrote: > On Thu, Jun 23, 2016 at 10:25:52AM +0100, Markos Chandras wrote: >> Add the missing braces to the 'if' statements to fix the misleading >> identation. This also fixes the following build errors when building >> with gcc >= 6: >> >> driver

[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

t dpdk.org; Markos Chandras > > Subject: Re: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' > > statements > > > > 2016-06-24 00:43, Lu, Wenzhuo: > > > Thanks for this patch. But normally the code in the base directory is > > > synce

[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

On Thu, Jun 23, 2016 at 10:25:52AM +0100, Markos Chandras wrote: > Add the missing braces to the 'if' statements to fix the misleading > identation. This also fixes the following build errors when building > with gcc >= 6: > > drivers/net/e1000/base/e1000_phy.c:4156:2: > error: this 'if' clause do

[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

2016-06-24 00:43, Lu, Wenzhuo: > Thanks for this patch. But normally the code in the base directory is synced > from the kernel driver. So we don't change it if there's no critical issue. > It's easy for us to maintain it. Thanks. I think a build error is critical enough.

[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

Hi Thomas, Markos, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, June 24, 2016 3:13 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org; Markos Chandras > Subject: Re: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the

[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

Hi Markos, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Markos Chandras > Sent: Thursday, June 23, 2016 5:26 PM > To: dev at dpdk.org > Cc: Markos Chandras > Subject: [dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if

[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

On Thu, Jun 23, 2016 at 4:04 PM, Markos Chandras wrote: > I have seen your commit, but my patch fixes a different file (although the > fix is similar). > > Am I missing something? > ?ah no. my bad. sorry about that. ?-- thanks anupam?

[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

hi markos, please see : cba50f6be0db9efdf694dcf4bce4a6945a275182, which should already fix this. -- thanks anupam On Thu, Jun 23, 2016 at 2:55 PM, Markos Chandras wrote: > Add the missing braces to the 'if' statements to fix the misleading > identation. This also fixes the following build err

[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

Hi Anupam, I have seen your commit, but my patch fixes a different file (although the fix is similar). Am I missing something? On 2016-06-23 11:26, Anupam Kapoor wrote: > hi markos, > > please see : cba50f6be0db9efdf694dcf4bce4a6945a275182, which should > already > fix this. > > -- > thanks

[dpdk-dev] [PATCH] e1000/base: Add missing braces to the 'if' statements

Add the missing braces to the 'if' statements to fix the misleading identation. This also fixes the following build errors when building with gcc >= 6: drivers/net/e1000/base/e1000_phy.c:4156:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation] if (locked) ^~ drivers/net/