Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-25 Thread Xu, Rosen
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, October 25, 2018 18:26 > To: Shreyansh Jain ; Xu, Rosen > ; dev@dpdk.org > Cc: Zhang, Tianfei ; Hemant Agrawal > > Subject: Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue > 323

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-25 Thread Ferruh Yigit
On 10/23/2018 8:09 AM, Shreyansh Jain wrote: > Besides the comment I sent before about 'Fixes' before sign-off, a > single trivial comment inline ... > > On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: >> This patch fixes rte_eal_hotplug_add without checking return value issue >> >> Signed-o

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Ferruh Yigit
On 10/23/2018 11:43 AM, Shreyansh Jain wrote: > On Tuesday 23 October 2018 03:21 PM, Ferruh Yigit wrote: >> On 10/23/2018 8:09 AM, Shreyansh Jain wrote: >>> Besides the comment I sent before about 'Fixes' before sign-off, a >>> single trivial comment inline ... >>> >>> On Tuesday 23 October 2018 07

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Shreyansh Jain
On Tuesday 23 October 2018 03:21 PM, Ferruh Yigit wrote: > On 10/23/2018 8:09 AM, Shreyansh Jain wrote: >> Besides the comment I sent before about 'Fixes' before sign-off, a >> single trivial comment inline ... >> >> On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: >>> This patch fixes rte_eal_

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Ferruh Yigit
On 10/23/2018 8:09 AM, Shreyansh Jain wrote: > Besides the comment I sent before about 'Fixes' before sign-off, a > single trivial comment inline ... > > On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: >> This patch fixes rte_eal_hotplug_add without checking return value issue >> >> Signed-o

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Shreyansh Jain
Besides the comment I sent before about 'Fixes' before sign-off, a single trivial comment inline ... On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: > This patch fixes rte_eal_hotplug_add without checking return value issue > > Signed-off-by: Rosen Xu > Fixes: ef1e8ede3da5 ("raw/ifpga: add

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-22 Thread Shreyansh Jain
On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: > This patch fixes rte_eal_hotplug_add without checking return value issue > > Signed-off-by: Rosen Xu > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen...@intel.com > --- Fixes comes *before* signed-off. ..

[dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-22 Thread Rosen Xu
This patch fixes rte_eal_hotplug_add without checking return value issue Signed-off-by: Rosen Xu Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: rosen...@intel.com --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff