Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-16 Thread Alejandro Lucero
On Tue, May 16, 2017 at 11:02 AM, Thomas Monjalon wrote: > 16/05/2017 11:39, Alejandro Lucero: > > Maybe we need another feature for detected link speed report capability. > > > > There is already support for ETH_SPEED_NUM_NONE if the speed is not > defined > > or it can not be specified by the d

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-16 Thread Thomas Monjalon
16/05/2017 11:39, Alejandro Lucero: > Maybe we need another feature for detected link speed report capability. > > There is already support for ETH_SPEED_NUM_NONE if the speed is not defined > or it can not be specified by the device. Netronome has some firmwares > without that link speed report c

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-16 Thread Alejandro Lucero
Maybe we need another feature for detected link speed report capability. There is already support for ETH_SPEED_NUM_NONE if the speed is not defined or it can not be specified by the device. Netronome has some firmwares without that link speed report capability, although maybe we are not the only

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-15 Thread Thomas Monjalon
15/05/2017 10:40, Ferruh Yigit: > On 5/12/2017 4:48 PM, Thomas Monjalon wrote: > > 12/05/2017 12:49, Ferruh Yigit: > >> On 5/10/2017 2:51 PM, Thomas Monjalon wrote: > >>> 10/05/2017 15:10, Ferruh Yigit: > --- a/doc/guides/nics/features/bnx2x.ini > +++ b/doc/guides/nics/features/bnx2x.ini

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-15 Thread Ferruh Yigit
On 5/12/2017 4:48 PM, Thomas Monjalon wrote: > 12/05/2017 12:49, Ferruh Yigit: >> On 5/10/2017 2:51 PM, Thomas Monjalon wrote: >>> 10/05/2017 15:10, Ferruh Yigit: --- a/doc/guides/nics/features/bnx2x.ini +++ b/doc/guides/nics/features/bnx2x.ini @@ -4,6 +4,7 @@ ; Refer to defaul

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-12 Thread Thomas Monjalon
12/05/2017 12:49, Ferruh Yigit: > On 5/10/2017 2:51 PM, Thomas Monjalon wrote: > > 10/05/2017 15:10, Ferruh Yigit: > >> --- a/doc/guides/nics/features/bnx2x.ini > >> +++ b/doc/guides/nics/features/bnx2x.ini > >> @@ -4,6 +4,7 @@ > >> ; Refer to default.ini for the full list of available PMD feature

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-12 Thread Ferruh Yigit
On 5/10/2017 2:51 PM, Thomas Monjalon wrote: > 10/05/2017 15:10, Ferruh Yigit: >> --- a/doc/guides/nics/features/bnx2x.ini >> +++ b/doc/guides/nics/features/bnx2x.ini >> @@ -4,6 +4,7 @@ >> ; Refer to default.ini for the full list of available PMD features. >> ; >> [Features] >> +Speed capabiliti

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-10 Thread Thomas Monjalon
10/05/2017 15:10, Ferruh Yigit: > --- a/doc/guides/nics/features/bnx2x.ini > +++ b/doc/guides/nics/features/bnx2x.ini > @@ -4,6 +4,7 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Features] > +Speed capabilities = Y We should validate this feature only if the

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-10 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, May 10, 2017 2:11 PM > To: Shepard Siegel ; Ed Czeck > ; John Miller ; > Mcnamara, John ; Harish Patil > ; Rasesh Mody ; Rahul > Lakkireddy ; Hemant Agrawal > ; Shreyansh Jain ; Lu, > Wenzhuo ; Marcin Wojtas ; Michal > Krawczyk

[dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-10 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- Please check other features of PMD and document missing ones in features file. Thanks. --- doc/guides/nics/features/ark.ini | 1 + doc/guides/nics/features/bnx2x.ini| 1 + doc/guides/nics/features/bnx2x_vf.ini | 1 + doc/guides/nics/features/