Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-10-03 Thread Thomas Monjalon
03/10/2018 16:11, Ferruh Yigit: > On 9/25/2018 10:04 AM, Thomas Monjalon wrote: > > 25/09/2018 10:03, Ferruh Yigit: > >> On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -2025,7 +2025,7 @@ ixgbe_recv_pk

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-10-03 Thread Ferruh Yigit
On 9/25/2018 10:04 AM, Thomas Monjalon wrote: > 25/09/2018 10:03, Ferruh Yigit: >> On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -2025,7 +2025,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-25 Thread Thomas Monjalon
25/09/2018 10:03, Ferruh Yigit: > On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > >>> --- a/drivers/net/ixgbe/ixgbe_rxtx.c > >>> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > >>> @@ -2025,7 +2025,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf > >>> **rx_pkts, uint16_t nb_pkts, > >>> st

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-25 Thread Ferruh Yigit
On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > 24/09/2018 17:06, Ferruh Yigit: >> On 9/20/2018 1:18 AM, Thomas Monjalon wrote: >>> -#define false FALSE >>> -#define true TRUE >> >> TRUE and FALSE also defined in this patch, can we remove them too? >

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-24 Thread Thomas Monjalon
24/09/2018 17:06, Ferruh Yigit: > On 9/20/2018 1:18 AM, Thomas Monjalon wrote: > > -#define false FALSE > > -#define true TRUE > > TRUE and FALSE also defined in this patch, can we remove them too? I don't see the need to remove TRUE and FALSE. The

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-24 Thread Ferruh Yigit
On 9/20/2018 1:18 AM, Thomas Monjalon wrote: > When trying to include stdbool.h in DPDK base headers, there are a lot > of conflicts with drivers which redefine bool/true/false > in their compatibility layer. > > It is fixed by including stdbool.h in these drivers. > Some errors with usage of bool

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-24 Thread Ferruh Yigit
On 9/21/2018 3:49 PM, Thomas Monjalon wrote: > 21/09/2018 15:47, Ferruh Yigit: >> On 9/20/2018 1:18 AM, Thomas Monjalon wrote: >>> When trying to include stdbool.h in DPDK base headers, there are a lot >>> of conflicts with drivers which redefine bool/true/false >>> in their compatibility layer. >>

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-21 Thread Thomas Monjalon
21/09/2018 15:47, Ferruh Yigit: > On 9/20/2018 1:18 AM, Thomas Monjalon wrote: > > When trying to include stdbool.h in DPDK base headers, there are a lot > > of conflicts with drivers which redefine bool/true/false > > in their compatibility layer. > > > > It is fixed by including stdbool.h in the

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-21 Thread Ferruh Yigit
On 9/20/2018 1:18 AM, Thomas Monjalon wrote: > When trying to include stdbool.h in DPDK base headers, there are a lot > of conflicts with drivers which redefine bool/true/false > in their compatibility layer. > > It is fixed by including stdbool.h in these drivers. > Some errors with usage of bool

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-20 Thread Shaikh, Shahed
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, September 20, 2018 5:49 AM > To: Ferruh Yigit ; Rahul Lakkireddy > ; Wenzhuo Lu ; Qi > Zhang ; Xiao Wang ; > Konstantin Ananyev ; Mody, Rasesh > ; Patil, Harish ; Shaikh, > Shahed ; Yong Wang > Cc: dev@dpdk.org > Subject: [PAT

[dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-19 Thread Thomas Monjalon
When trying to include stdbool.h in DPDK base headers, there are a lot of conflicts with drivers which redefine bool/true/false in their compatibility layer. It is fixed by including stdbool.h in these drivers. Some errors with usage of bool type are also fixed in some drivers. Note: the driver q