Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-15 Thread Ferruh Yigit
On 5/15/2017 1:53 AM, Lu, Wenzhuo wrote: > Hi, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, May 12, 2017 6:33 PM >> To: John W. Linville; Legacy, Allain (Wind River); Peters, Matt (Wind River); >> Harish Patil; Rasesh Mody; Stephen Hurd; Ajit Khaparde; Doherty, Declan; L

Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-15 Thread Yuanhan Liu
On Mon, May 15, 2017 at 10:26:00AM +0100, Ferruh Yigit wrote: > On 5/15/2017 10:19 AM, Yuanhan Liu wrote: > > On Mon, May 15, 2017 at 10:17:43AM +0100, Ferruh Yigit wrote: > >> On 5/12/2017 11:33 AM, Ferruh Yigit wrote: > >>> remove __rte_unused instances that are not required. > >>> > >> > >> Hi Y

Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-15 Thread Ferruh Yigit
On 5/15/2017 10:19 AM, Yuanhan Liu wrote: > On Mon, May 15, 2017 at 10:17:43AM +0100, Ferruh Yigit wrote: >> On 5/12/2017 11:33 AM, Ferruh Yigit wrote: >>> remove __rte_unused instances that are not required. >>> >> >> Hi Yuanhan, >> >> Does this kind of refactoring patches, specially the ones cove

Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-15 Thread Yuanhan Liu
On Mon, May 15, 2017 at 10:17:43AM +0100, Ferruh Yigit wrote: > On 5/12/2017 11:33 AM, Ferruh Yigit wrote: > > remove __rte_unused instances that are not required. > > > > Hi Yuanhan, > > Does this kind of refactoring patches, specially the ones covering > multiple drivers, cause trouble (more c

Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-15 Thread Ferruh Yigit
On 5/12/2017 11:33 AM, Ferruh Yigit wrote: > remove __rte_unused instances that are not required. > Hi Yuanhan, Does this kind of refactoring patches, specially the ones covering multiple drivers, cause trouble (more conflicts) to you while getting patches for stable trees? If so, I can postpon

Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-15 Thread Ferruh Yigit
On 5/15/2017 3:31 AM, Yuanhan Liu wrote: > On Fri, May 12, 2017 at 11:33:03AM +0100, Ferruh Yigit wrote: >> remove __rte_unused instances that are not required. > > I'm wondering this is done by some scripts? Manually, unfortunately.. > > --yliu >

Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-14 Thread Yuanhan Liu
On Fri, May 12, 2017 at 11:33:03AM +0100, Ferruh Yigit wrote: > remove __rte_unused instances that are not required. I'm wondering this is done by some scripts? --yliu

Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-14 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Friday, May 12, 2017 6:33 PM > To: John W. Linville; Legacy, Allain (Wind River); Peters, Matt (Wind River); > Harish Patil; Rasesh Mody; Stephen Hurd; Ajit Khaparde; Doherty, Declan; Lu, > Wenzhuo; Marcin Wojtas; Michal Krawczyk; Guy

Re: [dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-12 Thread Legacy, Allain
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, May 12, 2017 6:33 AM > To: John W. Linville; Legacy, Allain; Peters, Matt; Harish Patil; Rasesh Mody; > Stephen Hurd; Ajit Khaparde; DOHERTY, DECLAN; LU, WENZHUO; Marcin > Wojtas; Michal Krawczyk; Guy

[dpdk-dev] [PATCH] driver/net: remove unnecessary macro for unused variables

2017-05-12 Thread Ferruh Yigit
remove __rte_unused instances that are not required. Signed-off-by: Ferruh Yigit --- drivers/net/af_packet/rte_eth_af_packet.c | 7 ++- drivers/net/avp/avp_ethdev.c | 3 +-- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++-- drivers/net/bnxt/bnxt_ethdev.c | 2