Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-28 Thread Matan Azrad
Hi Thomas From: Thomas Monjalon: > 24/07/2020 17:43, Matan Azrad: > > Hi Thomas > > > > From: Thomas Monjalon: > > > 19/07/2020 13:41, Matan Azrad: > > > > > > > > From: Thomas Monjalon: > > > > > 19/07/2020 12:56, Matan Azrad: > > > > > > > > > > > > From: Thomas Monjalon > > > > > > > The detect

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-28 Thread Thomas Monjalon
24/07/2020 17:43, Matan Azrad: > Hi Thomas > > From: Thomas Monjalon: > > 19/07/2020 13:41, Matan Azrad: > > > > > > From: Thomas Monjalon: > > > > 19/07/2020 12:56, Matan Azrad: > > > > > > > > > > From: Thomas Monjalon > > > > > > The detection of the CPU was done in a constructor and shared in

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-24 Thread Matan Azrad
Hi Thomas From: Thomas Monjalon: > 19/07/2020 13:41, Matan Azrad: > > > > From: Thomas Monjalon: > > > 19/07/2020 12:56, Matan Azrad: > > > > > > > > From: Thomas Monjalon > > > > > The detection of the CPU was done in a constructor and shared in > > > > > a global variable. > > > > > > > > > > Th

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-24 Thread David Marchand
On Sun, Jul 19, 2020 at 12:09 PM Thomas Monjalon wrote: > > The detection of the CPU was done in a constructor and shared > in a global variable. > > This variable may not be visible in the net PMD > because it was not exported as part of the .map file. > It is fixed by exporting a function, which

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Thomas Monjalon
19/07/2020 13:41, Matan Azrad: > > From: Thomas Monjalon: > > 19/07/2020 12:56, Matan Azrad: > > > > > > From: Thomas Monjalon > > > > The detection of the CPU was done in a constructor and shared in a > > > > global variable. > > > > > > > > This variable may not be visible in the net PMD because

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Matan Azrad
From: Thomas Monjalon: > 19/07/2020 12:56, Matan Azrad: > > > > From: Thomas Monjalon > > > The detection of the CPU was done in a constructor and shared in a > > > global variable. > > > > > > This variable may not be visible in the net PMD because it was not > > > exported as part of the .map

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Thomas Monjalon
19/07/2020 12:56, Matan Azrad: > > From: Thomas Monjalon > > The detection of the CPU was done in a constructor and shared in a global > > variable. > > > > This variable may not be visible in the net PMD because it was not exported > > as part of the .map file. > > Can you explain exactly when

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Matan Azrad
From: Thomas Monjalon > The detection of the CPU was done in a constructor and shared in a global > variable. > > This variable may not be visible in the net PMD because it was not exported > as part of the .map file. Can you explain exactly when it is not visible? > It is fixed by exporting

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, July 19, 2020 13:08 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Shiri Kuzin > ; sta...@dpdk.org; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko ; Ray Kinsella ; > Neil Horman > Subject: [PATCH] common/mlx5: fix CPU detection

[dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-19 Thread Thomas Monjalon
The detection of the CPU was done in a constructor and shared in a global variable. This variable may not be visible in the net PMD because it was not exported as part of the .map file. It is fixed by exporting a function, which is cleaner than a variable. By checking the CPU only at the first ca