Re: [dpdk-dev] [PATCH] bus/pci: fix numa node return value

2021-09-24 Thread Varghese, Vipin
Hi Pallavi, Assuming the intention is set SOCKET_ID_ANY for faulty cases, couple of observation. In Linux ``` if (access(filename, F_OK) != -1) { if (eal_parse_sysfs_value(filename, &tmp) == 0) dev->device.numa_node = tmp; else

Re: [dpdk-dev] [PATCH] bus/pci: fix numa node return value

2021-09-23 Thread Tal Shnaiderman
> Subject: [PATCH] bus/pci: fix numa node return value > > External email: Use caution opening links or attachments > > > On older CPUs, currently numa_node returns value only for socket 0. > Instead, application should be able to make correct decision and also to keep > consistent with the Linu

Re: [dpdk-dev] [PATCH] bus/pci: fix numa node return value

2021-09-23 Thread Thomas Monjalon
23/09/2021 17:44, Tal Shnaiderman: > > Subject: [PATCH] bus/pci: fix numa node return value > > > > On older CPUs, currently numa_node returns value only for socket 0. > > Instead, application should be able to make correct decision and also to > > keep > > consistent with the Linux code, replace

[dpdk-dev] [PATCH] bus/pci: fix numa node return value

2021-09-22 Thread Pallavi Kadam
On older CPUs, currently numa_node returns value only for socket 0. Instead, application should be able to make correct decision and also to keep consistent with the Linux code, replace the return value to -1. Fixes: ac7c98d04f2c ("bus/pci: ignore missing NUMA node on Windows") Cc: tal...@nvidia.c