Re: [dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-23 Thread Andrew Rybchenko
On 4/23/19 6:04 PM, Ferruh Yigit wrote: On 4/23/2019 4:02 PM, Ferruh Yigit wrote: On 4/12/2019 2:12 PM, Andrew Rybchenko wrote: Setting exact link speed makes sense if auto-negotiation is disabled. Fixed flag is required to disable auto-negotiation. Hi Andrew, Fixed link speed is not supporte

Re: [dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-23 Thread Ferruh Yigit
On 4/23/2019 4:02 PM, Ferruh Yigit wrote: > On 4/12/2019 2:12 PM, Andrew Rybchenko wrote: >> Setting exact link speed makes sense if auto-negotiation is >> disabled. Fixed flag is required to disable auto-negotiation. > > Hi Andrew, > > Fixed link speed is not supported by all PMDs and this chang

Re: [dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-23 Thread Ferruh Yigit
On 4/12/2019 2:12 PM, Andrew Rybchenko wrote: > Setting exact link speed makes sense if auto-negotiation is > disabled. Fixed flag is required to disable auto-negotiation. Hi Andrew, Fixed link speed is not supported by all PMDs and this change is breaking them to set the speed in testpmd. As lo

Re: [dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-12 Thread Iremonger, Bernard
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Friday, April 12, 2019 2:13 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] app/testpmd: set fixed flag when exact link speed is > ch

[dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-12 Thread Andrew Rybchenko
Setting exact link speed makes sense if auto-negotiation is disabled. Fixed flag is required to disable auto-negotiation. Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 12 ++--