Re: [dpdk-dev] [PATCH] app/testpmd: fix error detection in MTU command

2020-05-20 Thread Ferruh Yigit
+1 on the confusion. I don't have answers to all above question, but it would be great if you tackle this clarification task. > > > Shy > > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, May 19, 2020 5:58 PM > To: Shy Shyman ; dev@dpdk.org > C

Re: [dpdk-dev] [PATCH] app/testpmd: fix error detection in MTU command

2020-05-19 Thread Shy Shyman
Message- From: Ferruh Yigit Sent: Tuesday, May 19, 2020 5:58 PM To: Shy Shyman ; dev@dpdk.org Cc: Wenzhuo Lu ; Beilei Xing ; Bernard Iremonger ; xavier.hu...@huawei.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix error detection in MTU command On 5/18/2020 10:27 AM, Shy Shyman wrote: >

Re: [dpdk-dev] [PATCH] app/testpmd: fix error detection in MTU command

2020-05-19 Thread Ferruh Yigit
On 5/18/2020 10:27 AM, Shy Shyman wrote: > MTU is used in testpmd to set the maximum payload size for packets. > According to testpmd, the setting influnce RX only. > In rte_ethdev there's no relation between MTU setting and JUMBO offload or > rx_max_pkt_len. > > The previous fix in patch referenc

Re: [dpdk-dev] [PATCH] app/testpmd: fix error detection in MTU command

2020-05-19 Thread Iremonger, Bernard
Hi Shy > -Original Message- > From: Shy Shyman > Sent: Monday, May 18, 2020 10:27 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; xavier.hu...@huawei.com > Subject: [PATCH] app/testpmd: fix error detection in MTU command > > MTU is used in testpmd to set

Re: [dpdk-dev] [PATCH] app/testpmd: fix error detection in MTU command

2020-05-19 Thread Asaf Penso
Regards, Asaf Penso > -Original Message- > From: dev On Behalf Of Shy Shyman > Sent: Monday, May 18, 2020 12:27 PM > To: dev@dpdk.org > Cc: Wenzhuo Lu ; Beilei Xing > ; Bernard Iremonger > ; xavier.hu...@huawei.com > Subject: [dpdk-dev] [PATCH] app/testpmd: fi

[dpdk-dev] [PATCH] app/testpmd: fix error detection in MTU command

2020-05-18 Thread Shy Shyman
MTU is used in testpmd to set the maximum payload size for packets. According to testpmd, the setting influnce RX only. In rte_ethdev there's no relation between MTU setting and JUMBO offload or rx_max_pkt_len. The previous fix in patch referenced below was meant to update the correlated variables