Re: [dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe

2017-06-16 Thread Thomas Monjalon
16/06/2017 03:29, Lu, Wenzhuo: > From: Nicolau, Radu > > > > Looks ok to me, but why would one enable IXGBE_BYPASS without enabling > > IXGBE? > > Although the scenario doesn't make sense, I think it's better to add more > check to avoid the users making any mistake. Applied

Re: [dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe

2017-06-15 Thread Lu, Wenzhuo
Hi Radu, > -Original Message- > From: Nicolau, Radu > Sent: Thursday, June 15, 2017 7:37 PM > To: Thomas Monjalon > Cc: Lu, Wenzhuo; dev@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix build without ixgbe > > Looks ok to me, but why would one enable IXGBE_BYPASS without enabling > IXGBE?

Re: [dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe

2017-06-15 Thread Thomas Monjalon
15/06/2017 12:17, Thomas Monjalon: > cmd_set_vf_rxmode_parsed() was defined only in the build context > of RTE_LIBRTE_IXGBE_PMD: > app/test-pmd/cmdline.c:13817:27: error: ‘cmd_set_vf_rxmode’ undeclared here > > Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") > > Reported-by: Jan Viktor

Re: [dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe

2017-06-15 Thread Thomas Monjalon
15/06/2017 13:37, Radu Nicolau: > Looks ok to me, but why would one enable IXGBE_BYPASS without enabling > IXGBE? [...] > > -#ifdef RTE_LIBRTE_IXGBE_BYPASS > > +#if defined RTE_LIBRTE_IXGBE_PMD && defined RTE_LIBRTE_IXGBE_BYPASS RTE_LIBRTE_IXGBE_BYPASS should not be enabled if RTE_LIBRTE_IXGBE_PM

Re: [dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe

2017-06-15 Thread Radu Nicolau
Looks ok to me, but why would one enable IXGBE_BYPASS without enabling IXGBE? On 6/15/2017 10:54 AM, Thomas Monjalon wrote: When ixgbe bypass is not explictly disabled while ixgbe is disabled: app/test-pmd/testpmd.c:304:27: error: ‘RTE_PMD_IXGBE_BYPASS_TMT_OFF’ undeclared here The ixg

[dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe

2017-06-15 Thread Thomas Monjalon
cmd_set_vf_rxmode_parsed() was defined only in the build context of RTE_LIBRTE_IXGBE_PMD: app/test-pmd/cmdline.c:13817:27: error: ‘cmd_set_vf_rxmode’ undeclared here Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Reported-by: Jan Viktorin Signed-off-by: Thomas Monjalon --- app/test

[dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe

2017-06-15 Thread Thomas Monjalon
When ixgbe bypass is not explictly disabled while ixgbe is disabled: app/test-pmd/testpmd.c:304:27: error: ‘RTE_PMD_IXGBE_BYPASS_TMT_OFF’ undeclared here The ixgbe bypass feature is meaningful only if ixgbe is enabled. So we need to check both. A best fix will be to enable bypass always a