Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-27 Thread Shahaf Shuler
Friday, January 26, 2018 10:36 AM, Thomas Monjalon: > 26/01/2018 09:06, Lu, Wenzhuo: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 26/01/2018 08:30, Lu, Wenzhuo: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > 25/01/2018 02:11, Lu, Wenzhuo: > > > > > Why these of

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-26 Thread Thomas Monjalon
26/01/2018 09:06, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 26/01/2018 08:30, Lu, Wenzhuo: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 25/01/2018 02:11, Lu, Wenzhuo: > > > > > > --- a/app/test-pmd/testpmd.c > > > > > > +++ b/app/test-pmd/testpmd.c >

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-26 Thread Lu, Wenzhuo
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, January 26, 2018 3:48 PM > To: Lu, Wenzhuo > Cc: Moti Haimovsky ; dev@dpdk.org; > shah...@mellanox.com; Yigit, Ferruh > Subject: Re: [PATCH] app/testpmd: do not enable Rx offloads by default > > 26/

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-25 Thread Thomas Monjalon
26/01/2018 08:31, Lu, Wenzhuo: > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > On Thu, 25 Jan 2018 10:04:11 +0100 > > Thomas Monjalon wrote: > > > 25/01/2018 02:11, Lu, Wenzhuo: > > > > > --- a/app/test-pmd/testpmd.c > > > > > +++ b/app/test-pmd/testpmd.c > > > > > @@ -305,9 +305

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-25 Thread Thomas Monjalon
26/01/2018 08:30, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 25/01/2018 02:11, Lu, Wenzhuo: > > > > --- a/app/test-pmd/testpmd.c > > > > +++ b/app/test-pmd/testpmd.c > > > > @@ -305,9 +305,7 @@ struct fwd_engine * fwd_engines[] = { > > > > */ > > > > struct rte_eth_rxm

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-25 Thread Lu, Wenzhuo
t: Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by > default > > On Thu, 25 Jan 2018 10:04:11 +0100 > Thomas Monjalon wrote: > > > 25/01/2018 02:11, Lu, Wenzhuo: > > > > --- a/app/test-pmd/testpmd.c > > > > +++ b/app/test-pmd/

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-25 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, January 25, 2018 5:04 PM > To: Lu, Wenzhuo > Cc: Moti Haimovsky ; dev@dpdk.org; > shah...@mellanox.com; Yigit, Ferruh > Subject: Re: [PATCH] app/testpmd: do not enable Rx offloads by de

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-25 Thread Stephen Hemminger
On Thu, 25 Jan 2018 10:04:11 +0100 Thomas Monjalon wrote: > 25/01/2018 02:11, Lu, Wenzhuo: > > > --- a/app/test-pmd/testpmd.c > > > +++ b/app/test-pmd/testpmd.c > > > @@ -305,9 +305,7 @@ struct fwd_engine * fwd_engines[] = { > > > */ > > > struct rte_eth_rxmode rx_mode = { > > > .max_rx_pkt_

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-25 Thread Thomas Monjalon
25/01/2018 02:11, Lu, Wenzhuo: > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -305,9 +305,7 @@ struct fwd_engine * fwd_engines[] = { > > */ > > struct rte_eth_rxmode rx_mode = { > > .max_rx_pkt_len = ETHER_MAX_LEN, /**< Default maximum frame > > length. */ > > - .

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-24 Thread Lu, Wenzhuo
Hi Moti, > -Original Message- > From: Moti Haimovsky [mailto:mo...@mellanox.com] > Sent: Tuesday, January 23, 2018 4:11 PM > To: Lu, Wenzhuo ; tho...@monjalon.net > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [PATCH] app/testpmd: do not enable Rx offloads by default > > Removed the hard

[dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-23 Thread Moti Haimovsky
Removed the hardcoded preconfigured Rx offload configuration from testpmd. Testers who wish to use these offloads will now have to explicitly write them in the command-line when running testpmd. Motivation: Some PMDs such at the mlx4 may not implement all the offloads. After the offload API rework