Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported

2018-05-11 Thread Ferruh Yigit
dev@dpdk.org; Dai, Wei ; Zhang, Qi Z >> >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload >> supported >> >> Thursday, May 10, 2018 1:09 AM, Ferruh Yigit: >>> Subject: [PATCH] app/testpmd: check if CRC strip offload supported >>> >>&

Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported

2018-05-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Thursday, May 10, 2018 5:39 AM > To: Yigit, Ferruh ; Lu, Wenzhuo > ; Wu, Jingjing > Cc: dev@dpdk.org; Dai, Wei ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH] a

Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported

2018-05-09 Thread Shahaf Shuler
Thursday, May 10, 2018 1:09 AM, Ferruh Yigit: > Subject: [PATCH] app/testpmd: check if CRC strip offload supported > > Testpmd set CRC_STRIP offload blindly, this is wrong according offload API > definition, and will cause error for the PMDs that doesn't support CRC_STRIP > like virtual PMDs. > >

[dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported

2018-05-09 Thread Ferruh Yigit
Testpmd set CRC_STRIP offload blindly, this is wrong according offload API definition, and will cause error for the PMDs that doesn't support CRC_STRIP like virtual PMDs. Check if underlying device report this capability and don't set it if not supported. Fixes: 0074d02fca21 ("app/testpmd: conver