Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-05-07 Thread Ferruh Yigit
On 5/6/2019 9:09 AM, Andrew Rybchenko wrote: > On 5/4/19 11:45 PM, Thomas Monjalon wrote: >> 02/05/2019 22:27, Thomas Monjalon: >>> 02/05/2019 20:31, Ferruh Yigit: On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > 25/04/2019 17:27, Ferruh Yigit: >> On 4/25/2019 2:29 PM, Thomas Monjalon w

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-05-06 Thread Andrew Rybchenko
On 5/4/19 11:45 PM, Thomas Monjalon wrote: 02/05/2019 22:27, Thomas Monjalon: 02/05/2019 20:31, Ferruh Yigit: On 4/29/2019 10:52 AM, Thomas Monjalon wrote: 25/04/2019 17:27, Ferruh Yigit: On 4/25/2019 2:29 PM, Thomas Monjalon wrote: 25/04/2019 13:47, Ferruh Yigit: On 4/25/2019 9:19 AM, Thom

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-05-04 Thread Thomas Monjalon
02/05/2019 22:27, Thomas Monjalon: > 02/05/2019 20:31, Ferruh Yigit: > > On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > > > 25/04/2019 17:27, Ferruh Yigit: > > >> On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > > >>> 25/04/2019 13:47, Ferruh Yigit: > > On 4/25/2019 9:19 AM, Thomas Monjalon wro

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-05-02 Thread Thomas Monjalon
02/05/2019 20:31, Ferruh Yigit: > On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > > 25/04/2019 17:27, Ferruh Yigit: > >> On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > >>> 25/04/2019 13:47, Ferruh Yigit: > On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > > 25/04/2019 00:03, Ferruh Yigit: > >

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-05-02 Thread Ferruh Yigit
On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > 25/04/2019 17:27, Ferruh Yigit: >> On 4/25/2019 2:29 PM, Thomas Monjalon wrote: >>> 25/04/2019 13:47, Ferruh Yigit: On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > 25/04/2019 00:03, Ferruh Yigit: >> This reverts commit bdca79053b6aea504d02

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-04-29 Thread Thomas Monjalon
25/04/2019 17:27, Ferruh Yigit: > On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > > 25/04/2019 13:47, Ferruh Yigit: > >> On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > >>> 25/04/2019 00:03, Ferruh Yigit: > This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > > Not all PMDs

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-04-25 Thread Ferruh Yigit
On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > 25/04/2019 13:47, Ferruh Yigit: >> On 4/25/2019 9:19 AM, Thomas Monjalon wrote: >>> 25/04/2019 00:03, Ferruh Yigit: This reverts commit bdca79053b6aea504d02691d9319fa976062457f. Not all PMDs support the fixed link speed set, and link spe

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-04-25 Thread Thomas Monjalon
25/04/2019 13:47, Ferruh Yigit: > On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > > 25/04/2019 00:03, Ferruh Yigit: > >> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > >> > >> Not all PMDs support the fixed link speed set, and link speed can be set > >> even with auto negotiation en

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-04-25 Thread Ferruh Yigit
On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > 25/04/2019 00:03, Ferruh Yigit: >> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. >> >> Not all PMDs support the fixed link speed set, and link speed can be set >> even with auto negotiation enabled. Reverting the patch to not break >> e

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-04-25 Thread Thomas Monjalon
25/04/2019 00:03, Ferruh Yigit: > This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > > Not all PMDs support the fixed link speed set, and link speed can be set > even with auto negotiation enabled. Reverting the patch to not break > existing usage. Which PMDs do not support this flag

[dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-04-24 Thread Ferruh Yigit
This reverts commit bdca79053b6aea504d02691d9319fa976062457f. Not all PMDs support the fixed link speed set, and link speed can be set even with auto negotiation enabled. Reverting the patch to not break existing usage. Signed-off-by: Ferruh Yigit --- Cc: Andrew Rybchenko Cc: WenjieX A Li Cc: