[dpdk-dev] [PATCH] Make -Werror optional

2015-02-23 Thread Panu Matilainen
On 02/23/2015 03:55 PM, Neil Horman wrote: > On Mon, Feb 23, 2015 at 10:19:23AM +0200, Panu Matilainen wrote: >> On 02/21/2015 09:33 PM, Neil Horman wrote: >>> On Fri, Feb 20, 2015 at 05:55:21PM -0800, Stephen Hemminger wrote: On Thu, 12 Feb 2015 16:54:44 +0200 Panu Matilainen wrote: >>>

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-23 Thread Panu Matilainen
On 02/21/2015 09:33 PM, Neil Horman wrote: > On Fri, Feb 20, 2015 at 05:55:21PM -0800, Stephen Hemminger wrote: >> On Thu, 12 Feb 2015 16:54:44 +0200 >> Panu Matilainen wrote: >> >>> On 02/12/2015 04:38 PM, Stephen Hemminger wrote: On Thu, 12 Feb 2015 13:13:22 +0200 Panu Matilainen wrot

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-23 Thread Neil Horman
On Mon, Feb 23, 2015 at 10:19:23AM +0200, Panu Matilainen wrote: > On 02/21/2015 09:33 PM, Neil Horman wrote: > >On Fri, Feb 20, 2015 at 05:55:21PM -0800, Stephen Hemminger wrote: > >>On Thu, 12 Feb 2015 16:54:44 +0200 > >>Panu Matilainen wrote: > >> > >>>On 02/12/2015 04:38 PM, Stephen Hemminger

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-21 Thread Neil Horman
On Fri, Feb 20, 2015 at 05:55:21PM -0800, Stephen Hemminger wrote: > On Thu, 12 Feb 2015 16:54:44 +0200 > Panu Matilainen wrote: > > > On 02/12/2015 04:38 PM, Stephen Hemminger wrote: > > > On Thu, 12 Feb 2015 13:13:22 +0200 > > > Panu Matilainen wrote: > > > > > >> This adds new CONFIG_RTE_ERRO

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-20 Thread Stephen Hemminger
On Thu, 12 Feb 2015 16:54:44 +0200 Panu Matilainen wrote: > On 02/12/2015 04:38 PM, Stephen Hemminger wrote: > > On Thu, 12 Feb 2015 13:13:22 +0200 > > Panu Matilainen wrote: > > > >> This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable > >> fail-on-warning compile behavior, default

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-12 Thread Panu Matilainen
On 02/12/2015 04:38 PM, Stephen Hemminger wrote: > On Thu, 12 Feb 2015 13:13:22 +0200 > Panu Matilainen wrote: > >> This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable >> fail-on-warning compile behavior, defaulting to off. >> >> Failing build on warnings is a useful developer tool b

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-12 Thread Panu Matilainen
On 02/12/2015 02:08 PM, Bruce Richardson wrote: > On Thu, Feb 12, 2015 at 02:02:19PM +0200, Panu Matilainen wrote: >> On 02/12/2015 01:25 PM, Bruce Richardson wrote: >>> On Thu, Feb 12, 2015 at 01:13:22PM +0200, Panu Matilainen wrote: This adds new CONFIG_RTE_ERROR_ON_WARNING config option to

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-12 Thread Thomas Monjalon
2015-02-12 15:58, Panu Matilainen: > + # see if we're building from git > + ifneq ($(wildcard $(RTE_SDK)/.git),) > +DEVEL_BUILD := y > + endif Yes it allows to force DEVEL_BUILD to any value on command line. But please use RTE_ prefix.

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-12 Thread Bruce Richardson
On Thu, Feb 12, 2015 at 03:58:07PM +0200, Panu Matilainen wrote: > On 02/12/2015 02:08 PM, Bruce Richardson wrote: > >On Thu, Feb 12, 2015 at 02:02:19PM +0200, Panu Matilainen wrote: > >>On 02/12/2015 01:25 PM, Bruce Richardson wrote: > >>>On Thu, Feb 12, 2015 at 01:13:22PM +0200, Panu Matilainen w

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-12 Thread Panu Matilainen
On 02/12/2015 01:25 PM, Bruce Richardson wrote: > On Thu, Feb 12, 2015 at 01:13:22PM +0200, Panu Matilainen wrote: >> This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable >> fail-on-warning compile behavior, defaulting to off. >> >> Failing build on warnings is a useful developer tool

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-12 Thread Panu Matilainen
This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable fail-on-warning compile behavior, defaulting to off. Failing build on warnings is a useful developer tool but its bad for release tarballs which can and do get built with newer compilers than what was used/available during developme

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-12 Thread Bruce Richardson
On Thu, Feb 12, 2015 at 02:02:19PM +0200, Panu Matilainen wrote: > On 02/12/2015 01:25 PM, Bruce Richardson wrote: > >On Thu, Feb 12, 2015 at 01:13:22PM +0200, Panu Matilainen wrote: > >>This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable > >>fail-on-warning compile behavior, defaulti

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-12 Thread Bruce Richardson
On Thu, Feb 12, 2015 at 01:13:22PM +0200, Panu Matilainen wrote: > This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable > fail-on-warning compile behavior, defaulting to off. > > Failing build on warnings is a useful developer tool but its bad > for release tarballs which can and do g

[dpdk-dev] [PATCH] Make -Werror optional

2015-02-12 Thread Stephen Hemminger
On Thu, 12 Feb 2015 13:13:22 +0200 Panu Matilainen wrote: > This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable > fail-on-warning compile behavior, defaulting to off. > > Failing build on warnings is a useful developer tool but its bad > for release tarballs which can and do get bu