Helin
n 10/10/14 09:35, Zhang, Helin wrote:
> Hi Marc
>
>> [snip]
>> rte_kni_init() should be staying. Actually the asymmetry of the API nowadays
>> (no rte_kni_init, because fd is created during first alloc but an
>> rte_kni_close)
>> looks weird to me. Just an aside question, not related to thi
Hi Helin,
On 10/10/14 07:25, Zhang, Helin wrote:
> Hi Marc
>
> More comments added.
>
>> [snip]
>> We can easily end up with DPDK users having to tweak the default
>> MAX_KNI_IFACES before compiling DPDK every time, which is
>> definetely not desirable IMHO.
> Your idea is good! My
Hi Marc
> -Original Message-
> From: Marc Sune [mailto:marc.sune at bisdn.de]
> Sent: Friday, October 10, 2014 2:38 PM
> To: Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] KNI: use a memzone pool for KNI alloc/release
>
> Hi Helin,
>
Hi Marc
More comments added.
> -Original Message-
> From: Marc Sune [mailto:marc.sune at bisdn.de]
> Sent: Thursday, October 9, 2014 6:16 PM
> To: Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] KNI: use a memzone pool for KNI alloc/release
>
&g
Hi Helin,
inline and snipped. Let me know after reading this mail if you believe I
can already submit the v2 with the changes you suggested.
On 09/10/14 10:57, Zhang, Helin wrote:
> [snip]
I don't think the approach of pre-allocating on the first
rte_kni_alloc() would work (I already d
Hi Helin,
Inline and snipped. Thanks for the additional comments.
On 09/10/14 10:33, Zhang, Helin wrote:
> [snip]
>>> [snip]
>> It adds a new API call, rte_kni_init(max_kni_ifaces) that shall be
>> called before any call to rte_kni_alloc() if KNI is used.
>>> To avoid the additional inter
Hi Helin,
Thanks for the comments. Inline and snipped
On 09/10/14 09:32, Zhang, Helin wrote:
> Hi Marc
>
> Good explanation! Thank you very much! I add more comments for your code
> changes.
> One common comment for annotation, in DPDK, we do not use "//" to start
> annotation.
OK, "//" => "/
t;> Sent: Monday, September 29, 2014 6:16 PM
>> To: dev at dpdk.org
>> Subject: [dpdk-dev] [PATCH] KNI: use a memzone pool for KNI alloc/release
>>
>> This patch implements the KNI memzone pool in order to:
>>
>> * prevent memzone exhaustion when allocating/
ect: Re: [dpdk-dev] [PATCH] KNI: use a memzone pool for KNI alloc/release
>
> Hi Helin,
>
> Inline and snipped. Thanks for the additional comments.
>
> On 09/10/14 10:33, Zhang, Helin wrote:
> > [snip]
> >>> [snip]
> >>>>>> It adds a new
Hi Marc
Thanks for your clarification! I added more comments.
> -Original Message-
> From: Marc Sune [mailto:marc.sune at bisdn.de]
> Sent: Thursday, October 9, 2014 3:53 PM
> To: Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] KNI: use a memzone
ber 9, 2014 3:05 PM
> To: Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] KNI: use a memzone pool for KNI alloc/release
>
> Hi Helin,
>
> On 09/10/14 08:01, Zhang, Helin wrote:
> > Hi Marc
> >
> > Thanks for the idea on KNI! I have commen
ject: [dpdk-dev] [PATCH] KNI: use a memzone pool for KNI alloc/release
>
> This patch implements the KNI memzone pool in order to:
>
> * prevent memzone exhaustion when allocating/deallocating KNI
> interfaces.
What do you mean the "exhaustion"? Actually the memzones can b
This patch implements the KNI memzone pool in order to:
* prevent memzone exhaustion when allocating/deallocating KNI
interfaces.
* be able to allocate KNI interfaces with the same name as
previously deallocated ones.
It adds a new API call, rte_kni_init(max_kni_ifaces) that shall
be called b
13 matches
Mail list logo
