Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Anand Rawat
On 3/26/2019 9:46 AM, Bruce Richardson wrote: On Tue, Mar 26, 2019 at 03:35:36PM +, Jerin Jacob Kollanukkaran wrote: On Tue, 2019-03-26 at 14:40 +, Bruce Richardson wrote: It is painful due to the fact that, If it is windows ONLY file then developer need to test on Windows as well as it

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Bruce Richardson
On Tue, Mar 26, 2019 at 03:35:36PM +, Jerin Jacob Kollanukkaran wrote: > On Tue, 2019-03-26 at 14:40 +, Bruce Richardson wrote: > > > It is painful due to the fact that, If it is windows ONLY file then > > > developer need to test on Windows as well as it may break Windows. > > > If it is a

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-03-26 at 14:40 +, Bruce Richardson wrote: > > It is painful due to the fact that, If it is windows ONLY file then > > developer need to test on Windows as well as it may break Windows. > > If it is a common file, at least, it will be tested on one > > platform. > > So responsibly w

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Thomas Monjalon
26/03/2019 16:17, Bruce Richardson: > On Tue, Mar 26, 2019 at 04:07:26PM +0100, Thomas Monjalon wrote: > > 26/03/2019 15:41, Bruce Richardson: > > > On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote: > > > > 26/03/2019 14:37, Jerin Jacob Kollanukkaran: > > > > > On Tue, 2019-03-26 at

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Bruce Richardson
On Tue, Mar 26, 2019 at 04:07:26PM +0100, Thomas Monjalon wrote: > 26/03/2019 15:41, Bruce Richardson: > > On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote: > > > 26/03/2019 14:37, Jerin Jacob Kollanukkaran: > > > > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > > > >

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Thomas Monjalon
26/03/2019 15:41, Bruce Richardson: > On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote: > > 26/03/2019 14:37, Jerin Jacob Kollanukkaran: > > > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > > > However, my hope is that down the road we can have the def file > > > > ge

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Bruce Richardson
On Tue, Mar 26, 2019 at 02:55:41PM +0100, Thomas Monjalon wrote: > 26/03/2019 14:37, Jerin Jacob Kollanukkaran: > > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > > However, my hope is that down the road we can have the def file > > > generated > > > from the map file (or potentiall

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Bruce Richardson
On Tue, Mar 26, 2019 at 01:37:33PM +, Jerin Jacob Kollanukkaran wrote: > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > --- > > --- > > On Tue, Mar 26, 2019 at 10:32:34AM +, Jerin Jacob Kollanukkaran > > wrote:

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Thomas Monjalon
26/03/2019 14:37, Jerin Jacob Kollanukkaran: > On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > > However, my hope is that down the road we can have the def file > > generated > > from the map file (or potentially vice versa). Perhaps the meson > > python > > module could be used to all

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Jerin Jacob Kollanukkaran
On Tue, 2019-03-26 at 10:58 +, Bruce Richardson wrote: > --- > --- > On Tue, Mar 26, 2019 at 10:32:34AM +, Jerin Jacob Kollanukkaran > wrote: > > On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > > > adding a DEF file for