Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-26 Thread Ray Kinsella
On 26/03/2020 09:56, Pavan Nikhilesh Bhagavatula wrote: > >> -Original Message- >> From: Ray Kinsella >> Sent: Tuesday, March 24, 2020 8:08 PM >> To: Pavan Nikhilesh Bhagavatula ; Jerin >> Jacob Kollanukkaran ; Nithin Kumar Dabilpuram >> >> Cc: dev@dpdk.org; tho...@monjalon.net; >> da

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-26 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Ray Kinsella >Sent: Tuesday, March 24, 2020 8:08 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; Nithin Kumar Dabilpuram > >Cc: dev@dpdk.org; tho...@monjalon.net; >david.march...@redhat.com; mattias.ronnb...@ericsson.com; Kiran >Kumar Kokkilag

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-24 Thread Ray Kinsella
On 24/03/2020 09:40, Pavan Nikhilesh Bhagavatula wrote: > Hi Ray, > > I have tried to avoid hand unrolling loops and found the following > observations. > > 1. Although it decreases LOC it also takes away readability too. > Example: > Avoiding unrolled code below [SNIP] >

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-24 Thread Pavan Nikhilesh Bhagavatula
Hi Ray, I have tried to avoid hand unrolling loops and found the following observations. 1. Although it decreases LOC it also takes away readability too. Example: Avoiding unrolled code below priv[0].u64[0] = rte_node_mbuf_priv1(mbuf[0])->u; priv

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-20 Thread Ray Kinsella
On 19/03/2020 16:13, Pavan Nikhilesh Bhagavatula wrote: > > >> -Original Message- >> From: Ray Kinsella >> Sent: Thursday, March 19, 2020 9:21 PM >> To: Pavan Nikhilesh Bhagavatula ; Jerin >> Jacob Kollanukkaran ; Nithin Kumar Dabilpuram >> >> Cc: dev@dpdk.org; tho...@monjalon.net; >

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-19 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Ray Kinsella >Sent: Thursday, March 19, 2020 9:21 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; Nithin Kumar Dabilpuram > >Cc: dev@dpdk.org; tho...@monjalon.net; >david.march...@redhat.com; mattias.ronnb...@ericsson.com; Kiran >Kumar Kokkil

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-19 Thread Ray Kinsella
On 19/03/2020 14:22, Pavan Nikhilesh Bhagavatula wrote: >> On 18/03/2020 21:35, jer...@marvell.com wrote: >>> From: Pavan Nikhilesh >>> >>> Add IPv4 lookup process function for ip4_lookup >>> rte_node. This node performs LPM lookup using x86_64 >>> vector supported RTE_LPM API on every packet r

Re: [dpdk-dev] [EXT] Re: [PATCH v1 20/26] node: ipv4 lookup for x86

2020-03-19 Thread Pavan Nikhilesh Bhagavatula
>On 18/03/2020 21:35, jer...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Add IPv4 lookup process function for ip4_lookup >> rte_node. This node performs LPM lookup using x86_64 >> vector supported RTE_LPM API on every packet received >> and forwards it to a next node that is identified by >>