Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-06 Thread Anoob Joseph
Hi Radu, Akhil, Please see inline Thanks, Anoob > > On 9/6/2021 12:36 PM, Anoob Joseph wrote: > > Hi Radu, > > > >> Hi Akhil, I suppose they can be complementary, with this one being a > >> hard ESN limit that the user can enforce by setting the initial ESN > >> value - but there is no requirem

Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-06 Thread Nicolau, Radu
On 9/6/2021 12:36 PM, Anoob Joseph wrote: Hi Radu, Hi Akhil, I suppose they can be complementary, with this one being a hard ESN limit that the user can enforce by setting the initial ESN value - but there is no requirement to do so. Also, this change doesn't need explicit support added in th

Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-06 Thread Anoob Joseph
Hi Radu, > Hi Akhil, I suppose they can be complementary, with this one being a hard > ESN limit that the user can enforce by setting the initial ESN value - but > there > is no requirement to do so. Also, this change doesn't need explicit support > added in the PMDs. What is the actual use case

Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-06 Thread Nicolau, Radu
On 9/5/2021 3:47 PM, Akhil Goyal wrote: Hi Radu, -- Update ipsec_xform definition to include ESN field. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin B

Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

2021-09-05 Thread Akhil Goyal
Hi Radu, > -- > Update ipsec_xform definition to include ESN field. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > --- > lib/security/r