Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility

2021-06-23 Thread Dmitry Kozlyuk
2021-06-09 18:52 (UTC+0300), Dmitry Kozlyuk: > 2021-05-20 20:17 (UTC+), Akhil Goyal: > > > > > > 2021-05-20 18:59 (UTC+), Akhil Goyal: > > > > > Windows system headers define `s_addr`, `min`, and `max` macros which > > > > > break structure definitions containing fields with one of the

Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility

2021-06-17 Thread Tyler Retzlaff
On Thu, May 20, 2021 at 08:17:54PM +, Akhil Goyal wrote: > > > > Yes it makes more sense now. But ideally it should be fixed in windows. they won't be fixed in windows. it is extremely rare to withdraw something from a platform headers namespace and is avoided to maintain API compatibility

Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility

2021-06-09 Thread Dmitry Kozlyuk
2021-05-20 20:17 (UTC+), Akhil Goyal: > > > > 2021-05-20 18:59 (UTC+), Akhil Goyal: > > > > Windows system headers define `s_addr`, `min`, and `max` macros which > > > > break structure definitions containing fields with one of these names. > > > > Undefining those macros would break con

Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility

2021-05-20 Thread Akhil Goyal
> > 2021-05-20 18:59 (UTC+), Akhil Goyal: > > > Windows system headers define `s_addr`, `min`, and `max` macros which > > > break structure definitions containing fields with one of these names. > > > Undefining those macros would break consumer code that relies on > them. > > > > > > > From t

Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility

2021-05-20 Thread Dmitry Kozlyuk
2021-05-20 18:59 (UTC+), Akhil Goyal: > > Windows system headers define `s_addr`, `min`, and `max` macros which > > break structure definitions containing fields with one of these names. > > Undefining those macros would break consumer code that relies on them. > > > > From the commit messa

Re: [dpdk-dev] [EXT] [PATCH v3] doc: announce API changes for Windows compatibility

2021-05-20 Thread Akhil Goyal
> Windows system headers define `s_addr`, `min`, and `max` macros which > break structure definitions containing fields with one of these names. > Undefining those macros would break consumer code that relies on them. > >From the commit message the requirement for changing the structure definitio