Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-22 Thread Ori Kam
f...@tencent.com; > > liuzho...@chinaunicom.cn; zhaoyon...@huawei.com; o...@yunify.com; > > j...@netgate.com; hongjun...@intel.com; j.bromh...@titan-ic.com; > > d...@ntop.org; f...@napatech.com; arthur...@lionic.com; Parav Pandit > > > > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-19 Thread Guy Kaneti
.com; > > liuzho...@chinaunicom.cn; zhaoyon...@huawei.com; o...@yunify.com; > > j...@netgate.com; hongjun...@intel.com; j.bromh...@titan-ic.com; > > d...@ntop.org; f...@napatech.com; arthur...@lionic.com; Parav Pandit > > > > Subject: Re: [dpdk-dev] [EXT] [PAT

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-08 Thread Ori Kam
> >wush...@inspur.com; > >> yuying...@yxlink.com; fanchengg...@sunyainfo.com; > >> davidf...@tencent.com; liuzho...@chinaunicom.cn; > >> zhaoyon...@huawei.com; o...@yunify.com; j...@netgate.com; > >> hongjun...@intel.com; j.bromh...@titan-ic.com; d...@n

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-08 Thread Ori Kam
h...@inspur.com; > yuying...@yxlink.com; fanchengg...@sunyainfo.com; > davidf...@tencent.com; liuzho...@chinaunicom.cn; > zhaoyon...@huawei.com; o...@yunify.com; j...@netgate.com; > hongjun...@intel.com; j.bromh...@titan-ic.com; d...@ntop.org; > f...@napatech.com; arthur...@lionic.com; Parav

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-07 Thread Ori Kam
h.com; arthur...@lionic.com; Parav Pandit > > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core > functions > > > > > -Original Message- > > From: Ori Kam > > Sent: Tuesday, April 07, 2020 7:29 PM > > To: Guy Kaneti ; J

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-07 Thread Guy Kaneti
.@yxlink.com; > > fanchengg...@sunyainfo.com; davidf...@tencent.com; > > liuzho...@chinaunicom.cn; zhaoyon...@huawei.com; o...@yunify.com; > > j...@netgate.com; hongjun...@intel.com; j.bromh...@titan-ic.com; > > d...@ntop.org; f...@napatech.com; arthur...@lionic.com;

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-07 Thread Ori Kam
op.org; f...@napatech.com; arthur...@lionic.com; Parav Pandit > > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core > functions > > Hi Ori, > > >+int > >+rte_regexdev_register(struct rte_regexdev *dev) > >+{ > >+uint16_t dev_id

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-07 Thread Guy Kaneti
Hi Ori, >+int >+rte_regexdev_register(struct rte_regexdev *dev) >+{ >+ uint16_t dev_id; >+ int res; >+ >+ if (dev->dev_ops == NULL) { >+ RTE_REGEXDEV_LOG(ERR, "RegEx device invalid device ops\n"); >+ return -EINVAL; >+ } >+ if (regexdev_allocated(

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-07 Thread Jerin Jacob
On Tue, Apr 7, 2020 at 5:57 PM Thomas Monjalon wrote: > > 07/04/2020 07:49, Jerin Jacob: > > > > > > > > If it abstracts it properly adding vdev and PCI is a simple change. > > > > See > > > > > > > > lib/librte_eventdev/rte_eventdev_pmd_vdev.h > > > > lib/librte_eventdev/rte_eventdev_pmd_pci.h >

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-07 Thread Thomas Monjalon
07/04/2020 07:49, Jerin Jacob: > > > > > > If it abstracts it properly adding vdev and PCI is a simple change. > > > See > > > > > > lib/librte_eventdev/rte_eventdev_pmd_vdev.h > > > lib/librte_eventdev/rte_eventdev_pmd_pci.h > > > > > > I think, the common code should take from other matured subsy

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-07 Thread Jerin Jacob
j...@netgate.com; > > hongjun...@intel.com; j.bromh...@titan-ic.com; d...@ntop.org; > > f...@napatech.com; arthur...@lionic.com; Parav Pandit > > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core > > functions > > > > > > > > &g

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Ori Kam
.com; > yuying...@yxlink.com; fanchengg...@sunyainfo.com; > davidf...@tencent.com; liuzho...@chinaunicom.cn; > zhaoyon...@huawei.com; o...@yunify.com; j...@netgate.com; > hongjun...@intel.com; j.bromh...@titan-ic.com; d...@ntop.org; > f...@napatech.com; arthur...@lionic.com; Parav

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Jerin Jacob
> > > > If it abstracts it properly adding vdev and PCI is a simple change. > > See > > > > lib/librte_eventdev/rte_eventdev_pmd_vdev.h > > lib/librte_eventdev/rte_eventdev_pmd_pci.h > > > > I think, the common code should take from other matured subsystem instead if > > writing from scratch, > > >

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Ori Kam
; Parav Pandit > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core > functions > > On Mon, Apr 6, 2020 at 7:00 PM Thomas Monjalon > wrote: > > > > 06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > > > From: Pavan Nikhilesh Bhag

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Jerin Jacob
On Mon, Apr 6, 2020 at 7:00 PM Thomas Monjalon wrote: > > 06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > > From: Pavan Nikhilesh Bhagavatula > > >> >> From: Pavan Nikhilesh Bhagavatula > > >> >> > > >> >> Looks like this implementation is incomplete? > > >> >> I don't see any pmd specific help

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Thomas Monjalon
06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > From: Pavan Nikhilesh Bhagavatula > >> >> From: Pavan Nikhilesh Bhagavatula > >> >> > >> >> Looks like this implementation is incomplete? > >> >> I don't see any pmd specific helper functions for @see > >> >rte_cryptodev_pmd.c, > >> >> rte_eventdev

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-06 Thread Pavan Nikhilesh Bhagavatula
j.bromh...@titan-ic.com; d...@ntop.org; >> f...@napatech.com; arthur...@lionic.com; Thomas Monjalon >> ; Parav Pandit >> Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev >core >> functions >> >> Hi Ori, >> >> >> F

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-05 Thread Ori Kam
; Parav Pandit > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core > functions > > Hi Ori, > > >> From: dev On Behalf Of Pavan Nikhilesh > >Bhagavatula > >> > >> Looks like this implementation is incomplete? > >>

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-05 Thread Pavan Nikhilesh Bhagavatula
Hi Ori, >> From: dev On Behalf Of Pavan Nikhilesh >Bhagavatula >> >> Looks like this implementation is incomplete? >> I don't see any pmd specific helper functions for @see >rte_cryptodev_pmd.c, >> rte_eventdev_pmd* >> >I think the current implementation includes all needed functions, >at least f

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-05 Thread Ori Kam
Hi Pavan, Thanks for your review, PSB. Best, Ori > -Original Message- > From: dev On Behalf Of Pavan Nikhilesh Bhagavatula > > Looks like this implementation is incomplete? > I don't see any pmd specific helper functions for @see rte_cryptodev_pmd.c, > rte_eventdev_pmd* > I think the c

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

2020-04-04 Thread Pavan Nikhilesh Bhagavatula
Looks like this implementation is incomplete? I don't see any pmd specific helper functions for @see rte_cryptodev_pmd.c, rte_eventdev_pmd* >This commit introduce the API that is needed by the RegEx devices in >order to work with the RegEX lib. > >During the probe of a RegEx device, the device sh