Re: [dpdk-dev] [EXT] [PATCH 4/8] trace: avoid confusion on optarg

2020-05-04 Thread Sunil Kumar Kori
>-Original Message- >From: Sunil Kumar Kori >Sent: Tuesday, May 5, 2020 11:15 AM >To: David Marchand >Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob Kollanukkaran > >Subject: RE: [EXT] [PATCH 4/8] trace: avoid confusion on optarg > >>-Original Message- >>From: David Marchand >

Re: [dpdk-dev] [EXT] [PATCH 4/8] trace: avoid confusion on optarg

2020-05-04 Thread Sunil Kumar Kori
>-Original Message- >From: David Marchand >Sent: Monday, May 4, 2020 7:39 PM >To: Sunil Kumar Kori >Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob Kollanukkaran > >Subject: Re: [EXT] [PATCH 4/8] trace: avoid confusion on optarg > >On Mon, May 4, 2020 at 9:55 AM Sunil Kumar Kori >wrot

Re: [dpdk-dev] [EXT] [PATCH 4/8] trace: avoid confusion on optarg

2020-05-04 Thread David Marchand
On Mon, May 4, 2020 at 9:55 AM Sunil Kumar Kori wrote: > > Overall, it looks okay but I think "args" will be more relevant as each API > says XXX_args_save(). > What do you say ? No opinion, the function name itself indicates we are dealing with arguments. I can go with args if you like. -- D

Re: [dpdk-dev] [EXT] [PATCH 4/8] trace: avoid confusion on optarg

2020-05-04 Thread Sunil Kumar Kori
Overall, it looks okay but I think "args" will be more relevant as each API says XXX_args_save(). What do you say ? Regards Sunil Kumar Kori >-Original Message- >From: David Marchand >Sent: Monday, May 4, 2020 2:02 AM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran