Re: [dpdk-dev] [DPDK] net/ice: fix hash flow segmentation fault

2020-03-02 Thread Zhu, TaoX
Hi Xiaolong, Commit SHA length non-compliance will be modified in V2 patch. The reason why they did not return immediately after the error is that they need to release the allocated memory after the error, which is released uniformly in error processing, so they did not return directly. BR, Zhu

Re: [dpdk-dev] [DPDK] net/ice: fix hash flow segmentation fault

2020-03-02 Thread Ye Xiaolong
On 03/03, taox@intel.com wrote: >From: Zhu Tao > >Macro rte_errno is not a static value, so it needs to be updated in all >error handling code. > >Patch 'dc36bd5dfd' mistakenly consider that rte_errno is a constant, which >causes the unrecognized flow rule to be marked as recognition success.

[dpdk-dev] [DPDK] net/ice: fix hash flow segmentation fault

2020-03-02 Thread taox . zhu
From: Zhu Tao Macro rte_errno is not a static value, so it needs to be updated in all error handling code. Patch 'dc36bd5dfd' mistakenly consider that rte_errno is a constant, which causes the unrecognized flow rule to be marked as recognition success. Later, when the code tried to parse the flo